Resolve PHPStan-Strict errors: staticMethod.nameCase

Since phpstan-strict isn't in core should we be fixing this right now or work to get phpstan-strict into core first?

@smustgrave the issue will come for that, these batch of issues that I've created will allow us to add it without increasing the baseline.

There isn't a lot of them, and its easier to solve upfront.

@smustgrave created an outline at 📌 Resolve issues exposed by PHPStan Strict Active

So brought this up in slack and think these should be postponed till it’s agreed that phpstan strict will be added. Didn’t see a ticket for that discussion

Only temporarily postponing pending feedback on 📌 Resolve issues exposed by PHPStan Strict Active

If we decide there no harm in merging these we can put back into review and I'll put top of my list to review. Just want to make sure they'll be accepted first.

I added checkFunctionNameCase: true to the existing phpstan config and got the same result. As per #3487218-7: Resolve PHPStan-Strict errors: class.nameCase → we should fix these with or without phpstan enforcement, as they are clearly incorrect.

Have updated the IS with steps to reproduce not requiring the strict package.

Committed to 11.x - thanks!

larowlan → closed merge request !10172

Automatically closed - issue fixed for 2 weeks with no activity.