- Issue created by @nicxvan
- Merge request !10040Issue #3485117: Modified return docblock type. β (Closed) created by nexusnovaz
- π¬π§United Kingdom nexusnovaz
Hey, can MR !10040 please be reviewed. Pipelines had a couple of fails, but after a retest they were fine.
Thanks!
My original suggestion from π module_implements_alter is not supported by OOP hooks Active was incorrect. Change should be
@return static
.- π¬π§United Kingdom nexusnovaz
Hey,
Thanks for that. I wasn't too sure about the return type but also wasn't sure what the correct answer was. Thanks for the link to the coding standards for this issue too! Setting back to needs review before pipeline has run, but it should be good!
Thanks
- π¬π§United Kingdom catch
Commited/pushed to 11.x and cherry-picked to 11.1.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 2 months ago 4:29pm 17 February 2025