- Issue created by @nicxvan
- πΊπΈUnited States nicxvan
These can be converted manually using hook order I think. This likely needs documentation.
- πΊπΈUnited States nicxvan
nicxvan β changed the visibility of the branch 3483899-moduleimplementsalter-is-not to hidden.
- Merge request !10029Procedural only for module_implements_alter and cache_flush β (Open) created by nicxvan
This looks fine, so RTBC.
I do have two small out of scope questions:
- I don't see any test coverage for the existing deny list functionality. If there is actually isn't any, was this an intentional choice as something to be done later?
- The docblock return type hint for
HookCollectorPass::collectAllHookImplementations()
:@return \Drupal\Core\Extension\HookCollectorPass
has the wrong namespace. It probably should be@return $this
. Is it worth worth its own issue?
- πΊπΈUnited States nicxvan
Good catch, I can create follow ups for those.
- π¬π§United Kingdom catch
This looks good (and those two separate follow-ups sound good as well).
Committed/pushed to 11.x/11.1.x, thanks!
This was moved to Fixed in #19 π module_implements_alter is not supported by OOP hooks Active , but somehow it's still showing as RTBC?
- πΊπΈUnited States nicxvan
Weird on status, I created the followups though.
- π¬π§United Kingdom longwave UK
Sometimes that happens if the commit bot posts at the same time as the status was changed. If you see it happen feel free to re-save the issue status to what it was meant to be.
- π¬π§United Kingdom longwave UK
Though credits were lost too, fixing those here.
Automatically closed - issue fixed for 2 weeks with no activity.