Contrib.social

Fix stylelint issues.

Open on Drupal.org →
Created on 24 October 2024, 8 months ago

Problem/Motivation

Stylelint issues are occurring in the Stylelint job following the GitLab integration for the environment_indicator module. These need to be addressed to comply with Drupal CSS coding standards.

See: https://git.drupalcode.org/issue/environment_indicator-3481334/-/jobs/31...

css/environment_indicator.css
 11:3   ✖  Expected "z-index" to come before "font-weight"                                                                                                                                                                                order/properties-order
 13:3   ✖  Expected "right" to come before "left"                                                                                                                                                                                         order/properties-order
 15:37  ✖  Unexpected nonstandard direction                                                                                                                                                                                               function-linear-gradient-no-nonstandard-direction
 15:37  ✖  Replace "bottom,·rgba(207,207,207,0.3)·19%,·rgba(250,250,250,0.3)·60%,·rgba(255,255,255,0.3)·80%" with "⏎····bottom,⏎····rgba(207,·207,·207,·0.3)·19%,⏎····rgba(250,·250,·250,·0.3)·60%,⏎····rgba(255,·255,·255,·0.3)·80%⏎··"  prettier/prettier
 18:38  ✖  Replace "·font-size:·0.85em;·" with "⏎··font-size:·0.85em;⏎"                                                                                                                                                                   prettier/prettier
 19:46  ✖  Replace "·content:·"(";·" with "⏎··content:·"(";⏎"                                                                                                                                                                             prettier/prettier
 20:45  ✖  Replace "·content:·")";·" with "⏎··content:·")";⏎"                                                                                                                                                                             prettier/prettier
 22:27  ✖  Expected no more than 1 declaration                                                                                                                                                                                            declaration-block-single-line-max-declarations
 22:28  ✖  Replace "·overflow:·hidden;·margin:·0;·" with "⏎··overflow:·hidden;⏎··margin:·0;⏎"                                                                                                                                             prettier/prettier
 26:3   ✖  Expected "float" to come before "list-style"                                                                                                                                                                                   order/properties-order
 36:3   ✖  Expected "text-shadow" to come before "font-size"                                                                                                                                                                              order/properties-order
 37:3   ✖  Expected "border" to come before "text-shadow"                                                                                                                                                                                 order/properties-order
 41:22  ✖  Replace "DDD" with "ddd"                                                                                                                                                                                                       prettier/prettier
 48:3   ✖  Expected "margin-top" to come before "padding"                                                                                                                                                                                 order/properties-order
 53:3   ✖  Expected "text-align" to come before "font-size"                                                                                                                                                                               order/properties-order
 55:22  ✖  Replace "EDEDE" with "edede"                                                                                                                                                                                                   prettier/prettier
 58:39  ✖  Expected double colon pseudo-element notation                                                                                                                                                                                  selector-pseudo-element-colon-notation
 61:47  ✖  Expected double colon pseudo-element notation                                                                                                                                                                                  selector-pseudo-element-colon-notation
 64:49  ✖  Expected double colon pseudo-element notation                                                                                                                                                                                  selector-pseudo-element-colon-notation
 67:57  ✖  Expected double colon pseudo-element notation                                                                                                                                                                                  selector-pseudo-element-colon-notation
 72:3   ✖  Expected "padding" to come before "text-align"                                                                                                                                                                                 order/properties-order
 92:12  ✖  Replace "·.gin--vertical-toolbar·.toolbar-menu-administration·>·.toolbar-menu·>·.menu-item" with "⏎··.gin--vertical-toolbar⏎··.toolbar-menu-administration⏎··>·.toolbar-menu⏎··>·.menu-item⏎·"                                 prettier/prettier
 93:21  ✖  Replace "var(--gin-toolbar-width-collapsed,·var(--ginToolbarWidthCollapsed))·-·4px" with "⏎····var(--gin-toolbar-width-collapsed,·var(--ginToolbarWidthCollapsed))·-·4px⏎··"                                                   prettier/prettier
 93:60  ✖  Expected "--ginToolbarWidthCollapsed" to match pattern "^[a-z][-_a-z0-9IE]*$"                                                                                                                                                  custom-property-pattern
 96:12  ✖  Replace "·.gin--vertical-toolbar·.toolbar-menu-administration·>·.toolbar-menu·>·.menu-item" with "⏎··.gin--vertical-toolbar⏎··.toolbar-menu-administration⏎··>·.toolbar-menu⏎··>·.menu-item⏎·"                                 prettier/prettier
 97:22  ✖  Replace "var(--gin-toolbar-width-collapsed,·var(--ginToolbarWidthCollapsed))·-·4px" with "⏎····var(--gin-toolbar-width-collapsed,·var(--ginToolbarWidthCollapsed))·-·4px⏎··"                                                   prettier/prettier
 97:61  ✖  Expected "--ginToolbarWidthCollapsed" to match pattern "^[a-z][-_a-z0-9IE]*$"                                                                                                                                                  custom-property-pattern
27 problems (27 errors, 0 warnings)
1 source checked
 /builds/issue/environment_indicator-3481334/web/modules/custom/environment_indicator-3481334/css/environment_indicator.css
27 errors found
 order/properties-order: 8
 function-linear-gradient-no-nonstandard-direction: 1
 prettier/prettier: 11
 declaration-block-single-line-max-declarations: 1
 selector-pseudo-element-colon-notation: 4 (maybe fixable)
 custom-property-pattern: 2
You may fix some problems with the "--fix" option.

Steps to reproduce

  1. Clone the environment_indicator module repository.
  2. Set up the GitLab CI/CD environment.
  3. Run the Stylelint job.
  4. Check for linting errors in the job logs.

Proposed resolution

Update the CSS files to comply with Drupal CSS coding standards.

Remaining tasks

  • Fix specific Stylelint errors.
  • Test the Stylelint job after changes.

User interface changes

None.

API changes

None.

Data model changes

None.

📌 Task
Status

Active

Version

4.0

Component

Code

Created by

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @trackleft2
  • Comment 8 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
  • Comment 7 months ago →
    🇮🇳India arunsahijpal

    Working on it!

  • Comment 7 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    OK, but there will probably be merge conflicts with 📌 Fix cspell issues Active that you'll need to account for.

  • Merge request !74Issue #3483055 Fixed the stylelint errors. → (Merged) created by arunsahijpal
  • Pipeline finished with Success
    7 months ago
    Total: 137s
    #323818
  • Pipeline finished with Success
    7 months ago
    Total: 137s
    #323825
  • Pipeline finished with Success
    7 months ago
    Total: 129s
    #324014
  • Pipeline finished with Success
    7 months ago
    Total: 140s
    #324022
  • Pipeline finished with Success
    7 months ago
    Total: 133s
    #324027
  • Pipeline finished with Success
    7 months ago
    Total: 337s
    #324040
  • Pipeline finished with Success
    7 months ago
    Total: 130s
    #324048
  • Pipeline finished with Success
    7 months ago
    Total: 134s
    #324053
  • Comment 7 months ago →
    🇮🇳India arunsahijpal

    Hi @trackleft2,
    I've fixed all the Stylelint errors and there is not any merge conflict in the MR, kindly review it.

  • Comment 7 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    @arunsahijpal what about the gitlab part from the issue summary?

    Configure gitlab to not allow merging if stylelint job doesn't pass.

  • Pipeline finished with Failed
    7 months ago
    Total: 220s
    #328620
  • Pipeline finished with Failed
    7 months ago
    #328642
  • Pipeline finished with Failed
    7 months ago
    #328643
  • Pipeline finished with Failed
    7 months ago
    #328651
  • Pipeline finished with Failed
    7 months ago
    #328652
  • Pipeline finished with Failed
    7 months ago
    Total: 136s
    #328653
  • Pipeline finished with Failed
    7 months ago
    Total: 142s
    #328657
  • Pipeline finished with Success
    7 months ago
    Total: 143s
    #328661
  • Comment 7 months ago →
    🇮🇳India arunsahijpal

    Hi @trackleft2,
    I've configured gitlab-ci.yml file to not allow merging if stylelint job doesn't pass.
    Pls give it a look.

  • Comment 7 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    Thanks, nice work!

  • Pipeline finished with Failed
    6 months ago
    Total: 180s
    #371894
  • Pipeline finished with Failed
    6 months ago
    Total: 136s
    #371900
  • Pipeline finished with Success
    6 months ago
    Total: 147s
    #371910
  • Pipeline finished with Failed
    4 months ago
    Total: 141s
    #430807
  • Pipeline finished with Canceled
    4 months ago
    Total: 81s
    #430828
  • Pipeline finished with Failed
    4 months ago
    Total: 145s
    #430829
  • Pipeline finished with Failed
    4 months ago
    Total: 154s
    #430836
  • Pipeline finished with Failed
    4 months ago
    Total: 138s
    #430839
  • Pipeline finished with Failed
    4 months ago
    Total: 157s
    #430846
  • Pipeline finished with Failed
    4 months ago
    Total: 157s
    #430858
  • Pipeline finished with Canceled
    4 months ago
    Total: 81s
    #430862
  • Pipeline finished with Failed
    4 months ago
    Total: 144s
    #430863
  • Pipeline finished with Failed
    4 months ago
    Total: 144s
    #430865
  • Status changed to Needs work 4 months ago
  • Comment 4 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    Needs work, there is an upstream merge conflict now.

  • Pipeline finished with Failed
    4 months ago
    Total: 143s
    #430866
  • Pipeline finished with Failed
    4 months ago
    Total: 151s
    #430867
  • Pipeline finished with Success
    4 months ago
    Total: 137s
    #430871
  • Comment 4 months ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    Updated this Merge Request to incorporate upstream changes from 🐛 Gin vertical toolbar submenu's overlap Active
    Note:
    - This merge request changes fallback variable names to comply with style lint rules (Possibly a breaking change for people using the old variable)

  • Status changed to Needs review 29 days ago
  • Comment 29 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    Once this is reviewed and merged we'll finally have all useful (passing) CI tests..

  • Comment 25 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    trackleft2 → changed the visibility of the branch 4.x to hidden.

  • Merge request !89Draft: Resolve #3483055 "Fix stylelint issues" Creating new MR in order to test with tugboat → (Open) created by trackleft2
  • Comment 25 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    trackleft2 → changed the visibility of the branch 3483055-fix-stylelint-issues-tugboat to hidden.

  • Comment 25 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
  • Comment 25 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    I've updated this to remove some SCSS that was added in here by mistake.

  • Comment 24 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

    I've reviewed this several times and I think it is ready for merging.

  • Comment 24 days ago →
    System Message
  • Comment 24 days ago →
    🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
  • Comment 10 days ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024