Update to jQuery UI 1.14.0

Created on 24 October 2024, 7 months ago

Problem/Motivation

jQuery UI 1.14.0 was released on August 5, 2024: https://jqueryui.com/changelog/1.14.0/
The module currently provides version 1.13.2:
https://git.drupalcode.org/project/jquery_ui/-/blob/8.x-1.x/assets/vendo...

Proposed resolution

Update to 1.14.0

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom malcomio

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @malcomio
  • 🇬🇧United Kingdom malcomio

    See also 📌 Update to jQuery UI 1.14.0 Fixed for core.

  • First commit to issue fork.
  • Merge request !19Update to jQuery UI 1.14.0 → (Open) created by rajeshreeputra
  • Status changed to Needs review 4 months ago
  • 🇧🇪Belgium flyke

    This MR only changes the reported version in assets/vendor/jquery.ui/ui/version.js.

    But all code is still 1.13.
    This causes errors when jquery_ui uses old stuff that is no longer present in 1.14.

    I get the error:
    An error occurred during the execution of the Ajax response: TypeError: i.ui.safeActiveElement is not a function

    According to the jQuery UI 1.14 changelog and release notes safeActiveElement is removed.

    However, if I scan the code of jquery_ui after using this patch for 'safeActiveElement', I get 31 results in 21 files.
    I think the correct amount should be zero.

    If I scan the code of jquery_ui after using this patch for '1.13.', I get 283 results in 122 files.
    I think the correct amount here should also be zero ?

    So this patch just pretends to do something by changing the reported version, but the reported version is a lie because none of the code has been updated ?

  • Pipeline finished with Success
    4 months ago
    Total: 141s
    #400852
  • 🇧🇪Belgium flyke

    So ehm... in the end my problem was not solved after updating jquery_ui.
    While I got no erros on my local development environment, on production I kept getting the error:
    An error occurred during the execution of the Ajax response: TypeError: i.ui.safeActiveElement is not a function

    After a deep dive down the rabbit hole, for some reason the error originated from:
    core/assets/vendor/jquery.ui/ui/widgets/menu-min.js

    That file is not in any gitignore file that I created but yet somehow after successful deployments, it does not seem to get updated after deployment. My local menu.min.js file does not contain 'safeActiveElement' but the one on the server after deployment still does.
    I checked the file directly in my projects repository, its the correct file in there. I cannot find any reason at all why the file on the server is still old version after deployment. The deployment script also clears caches two times, but still that does not help.

    I manually overridden the core/assets/vendor/jquery.ui/ui/widgets/menu-min.js on the server with that of my local environment via FileZilla, and now finally I got rid of the error on production and the modal link is working again.

  • #9 @flyke I have the same error in drupal 10.4.2

  • 🇺🇸United States recrit

    @flyke - with still having errors, then you are most likely running into 🐛 Remove duplicate modules in JavaScript bundles Active where some of the core files are still loaded. The patch in 3420890 gives the jquery_ui module full control over all the JS files.

    I am working on updating the patch to work with the updates in this issue for 1.14.1 since Drupal 10.4.x includes that version too.

  • Pipeline finished with Success
    about 1 month ago
    Total: 130s
    #476112
  • Pipeline finished with Success
    about 1 month ago
    Total: 138s
    #476127
  • 🇺🇸United States recrit

    I opened a new MR 20 that is MR 19 with the changes from 🐛 Remove duplicate modules in JavaScript bundles Active . The result is that jquery_ui is updated to 1.14.1 similar to Drupal core after 10.4.x and gives jquery_ui full control over the files with the changes from 🐛 Remove duplicate modules in JavaScript bundles Active .

    Attached is a static patch of MR 20 for any composer builds.

  • 🇺🇸United States recrit

    @flyke and @nelo_drup please test the MR 20 see comment #15 📌 Update to jQuery UI 1.14.0 Active for details.

Production build 0.71.5 2024