Use navigation sdc button

This broke Drupal CMS.

My MR fixes the WSOD, but I don't think the block is still functional, as I didn't get to open the tours.

Would check out https://www.drupal.org/project/tour/issues/3473594 🐛 Improve the tour block in the context of the navigation module Needs review

We’ve all been testing on 11.x without issues so far

there is a separate issue making the tour button a fully qualified navigation block button: 🐛 Improve the tour block in the context of the navigation module Needs review . so without that patch the button isnt behaving like other buttons in the navigation sidebar, in particular in the context of the tour layout page.

and i guess this issue is not necessarily a duplicate of the other issue. cuz i've tested on 11.x with 🐛 Improve the tour block in the context of the navigation module Needs review and i run into a WSOD.

@smurtgrave Probably it's better to work on the other issue, but it will need this commit anyway. This landed just today, so that's why worked for you :-)

i would suggest to commit this issue. cuz the other issue still needs some discussion and at the moment the site is completely broken with tour and the navigation module installed (i've tested as well, as mentioned in #8). if this issue would be committed as a hot fix then there wouldnt be that much of time pressure behind getting the other issue in.

See world explode.

Can confirm. Tried on 10.4.x. Enabling navigation alone, all is well. Enabling tour, world expolode.

The open MR fixes the world from exploding (aka the WSOD).

and i guess this issue is not necessarily a duplicate of the other issue. cuz i've tested on 11.x with #3473594: Improve the tour block in the context of the navigation module and i run into a WSOD (probably the same WSOD @penyaskito ran into?)

I agree. It would be the same issue there. This is stemming from a hot off the press merge to core in 📌 Migrate Toolbar button to SDC Needs review (literally today). I would suggest merging this fix to mitigate the WSOD, and then continue with the visual work on the button in 🐛 Improve the tour block in the context of the navigation module Needs review . The visual result after this MR is the same in screenshots on 🐛 Improve the tour block in the context of the navigation module Needs review , so feels safe to merge and continue on there.

Re-opening and marking RTBC.

Will put some work to get the other ticket in. But don’t think merging this in will work as it will break for those on 10.3

smustgrave → closed merge request !83

About to merge 🐛 Improve the tour block in the context of the navigation module Needs review

Removing tags from the dupe