Event To Calendar - 1.0.x-dev

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

This is ready for review. All the Drupal coding standards are met. Thank you.

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml event_to_calendar/

FILE: event_to_calendar/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------
  7 | WARNING | Line exceeds 80 characters; contains 328 characters
 10 | WARNING | Line exceeds 80 characters; contains 89 characters
 11 | WARNING | Line exceeds 80 characters; contains 89 characters
 12 | WARNING | Line exceeds 80 characters; contains 122 characters
 13 | WARNING | Line exceeds 80 characters; contains 90 characters
 14 | WARNING | Line exceeds 80 characters; contains 92 characters
 15 | WARNING | Line exceeds 80 characters; contains 88 characters
 16 | WARNING | Line exceeds 80 characters; contains 84 characters
 21 | WARNING | Line exceeds 80 characters; contains 93 characters
 22 | WARNING | Line exceeds 80 characters; contains 88 characters
 25 | WARNING | Line exceeds 80 characters; contains 183 characters
 33 | WARNING | Line exceeds 80 characters; contains 112 characters
----------------------------------------------------------------------

FILE: event_to_calendar/src/Plugin/Block/AddToCalendarBlock.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 96 | WARNING | Unused variable $start_date.
 97 | WARNING | Unused variable $end_date.
 98 | WARNING | Unused variable $location.
----------------------------------------------------------------------

FILE: event_to_calendar/src/Form/EventToCalendarConfigForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 34 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------

FILE: event_to_calendar/src/Controller/EventToCalendarController.php
----------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  32 | ERROR   | [x] Missing function doc comment
 140 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 164 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 462 | ERROR   | [ ] The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: event_to_calendar/css/styles.css
----------------------------------------------------------------------
FOUND 34 ERRORS AFFECTING 33 LINES
----------------------------------------------------------------------
  1 | ERROR | [x] Additional whitespace found at start of file
 14 | ERROR | [x] Whitespace found at end of line
 17 | ERROR | [x] Whitespace found at end of line
 28 | ERROR | [x] Selectors must be on a single line
 29 | ERROR | [x] Selectors must be on a single line
 30 | ERROR | [x] Selectors must be on a single line
 31 | ERROR | [x] Selectors must be on a single line
 32 | ERROR | [x] Selectors must be on a single line
 33 | ERROR | [x] Selectors must be on a single line
 34 | ERROR | [x] Selectors must be on a single line
 35 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 35 | ERROR | [ ] Style definitions must end with a semicolon
 37 | ERROR | [x] Blank lines are not allowed in class definitions
 59 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 63 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 83 | ERROR | [x] Whitespace found at end of line
 84 | ERROR | [x] Whitespace found at end of line
 87 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
 92 | ERROR | [x] Closing brace of class definition must be on new line
 95 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 33 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

2. Remove README.txt file since README.md is present.

3. FILE: event_to_calendar.info.yml

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

4. FILE: event_to_calendar.module

/**
 * @file
 * Contains event_to_calendar.module.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

5. FILE: templates/event-to-calendar.html.twig

Use 2 spaces for each level of indentation, the same standard as Drupal’s PHP and JavaScript code.

Move all scripts (JavaScript) and styles (CSS) into a library and attach them. See the process here → .

Hey @vishal please take a fresh clone and try to run the phpcs, since the coding standard fixes were done and merge into 1.0.x branch
1 hour ago. Let me know if there's the same issue, we can disucss further on this. Thank you.

I found the issue i will get these worked on and then send out for reveiw. Thank you.

I am changing priority as per Issue priorities → .