- Issue created by @ivnish
- First commit to issue fork.
- ivnish Kazakhstan
I pinged @dpi in slack https://drupal.slack.com/archives/C1BMUQ9U6/p1733138202393459
- 🇮🇳India ankitv18
@ivnish Either we need to fix this failing test: https://git.drupalcode.org/issue/smsframework-3480559/-/jobs/3547201#L72 or we can skip previous major pipeline.
- 🇦🇺Australia dpi Perth, Australia
It seems unlikely we need all of these changes to achieve Drupal 11 compatibility?
There is no justification documented for such large changes.
Lets stick to the minimum required changes.
- 🇦🇺Australia dpi Perth, Australia
I've merged Gitlab, linting, and test fixes for D10 in !20.
D10 is green, D11 is not.
I'm okay with deferring linting for now, please do not address PHPCS/PHPStan/CSpell, etc.
Except!, the two deprecation errors exposed by PHPStan should be fixed, despite having a deadline of Drupal 12. There doesn't seem to be any Drupal 11 deprecation messages exposed by PHPStan at all.
I'd appreciate if we can tear down all irrelevant parts of this MR, so what remains are the essential D11 green pieces.
- ivnish Kazakhstan
@dpi, I removed linting code and added only 2 phpstan fixes (Drupal 12 deprecations)
- 🇦🇺Australia dpi Perth, Australia
2.3.0 and 2.4.0 published, including these changes.
- Issue was unassigned.
- Status changed to Fixed
3 months ago 3:34am 23 December 2024 Automatically closed - issue fixed for 2 weeks with no activity.