[1.0.x] Translate Paragraph Asymetric (with AI)

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

main are wrong names for a branch. Release branch names always end with the literal .x as described in Release branches.

main will be a supported branch in future, but for the moment it is better not to use it. It is not wrong, but it is not completely supported on drupal.org.

Thanks for your remark, i changed the branch name to 1.0.x

Please go through comment #2 thoroughly.

Do not forgot to change status of the issue to Needs review when project is ready to review. in this queue only project status with 'Needs review' are reviewed.

Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ai_translate_paragraph_asymetric/

FILE: ai_translate_paragraph_asymetric/ai_translate_paragraph_asymetric.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ai_translate_paragraph_asymetric/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 12 | WARNING | Line exceeds 80 characters; contains 95 characters
 19 | WARNING | Line exceeds 80 characters; contains 115 characters
 21 | WARNING | Line exceeds 80 characters; contains 94 characters
--------------------------------------------------------------------------------

FILE: ai_translate_paragraph_asymetric/src/Plugin/FieldTextExtractor/ParagraphAsymetricExtractor.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ai_translate\Attribute\FieldTextExtractor.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ai_translate_paragraph_asymetric/src/Plugin/FieldTextExtractor/TextFieldParagraphAsymetricExtractor.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ai_translate\Attribute\FieldTextExtractor.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Thanks for you review,

I updated the .info file to add the missing line.

For the ai_translate_paragraph_asymetric/src/Plugin/FieldTextExtractor/TextFieldParagraphAsymetricExtractor.php not using the right alphabetical order in the "use", i believe it's fine, i had the issue before and it was because my "Drupal/coder" was not up to date.
Maybe you have the same issue?

For the Readme, is it mandatory to have that line size? it seems a bit too small if i respect this.

Plus, it seems to pass the default phpcs in the pipeline.

If you have enabled GitLab CI for the project, and the phpcs job runs for each commit, fix what reported by that GitLab CI job. Clearly, that is valid if the phpcs job has not been customized to avoid most of the PHP_CodeSniffer errors/warnings. 😉

It is the case, i enabled gitlab ci and the phpcs job runs without issues