- Issue created by @andybroomfield
- 🇬🇧United Kingdom andybroomfield
Changing
once('geoEntityGeocodeLeaflet', document.getElementById(formId)).forEach(function (form) {
to
once('geoEntityGeocodeLeaflet', document.querySelectorAll('form[id^="' + formId + '"]')).forEach(function (form) {
works. Might not be the most performant though. - 🇳🇱Netherlands ekes
I'm just trying to recreate this. Are there some steps I could follow?
- 🇬🇧United Kingdom andybroomfield
See the linked Github issue above:
- Create a new directory venue with a brand new geo entity as a location. This should geocode the map pin.
- Then edit said directory venue, and edit the location (not delete and replace).
- Clear out the address and try to add a new one. Whilst the autocomplete does replace it, the leaflet map pin and lat / lon fields are not updated.
- First commit to issue fork.
- 🇬🇧United Kingdom andybroomfield
Not sure why the tests are failing for @hannahdigidev MR. I've run the test suite locally with PHP 8.3 and 8.4 and they all pass.
% /opt/homebrew/opt/php@8.4/bin/php vendor/bin/phpunit web/modules/contrib/geo_entity --testdox
PHPUnit 9.6.23 by Sebastian Bergmann and contributors.Testing [redacted]/web/modules/contrib/geo_entity
Address Forms (Drupal\Tests\geo_entity_address\Functional\AddressForms)
✔ CrudGeonames Service (Drupal\Tests\geo_entity_tz\Unit\GeonamesService)
✔ Config missing
✔ Error
✔ ResponseGeo Bundle Creation (Drupal\Tests\geo_entity\Functional\GeoBundleCreation)
✔ Media type creation formGeo Overview Access (Drupal\Tests\geo_entity\Functional\GeoOverviewAccess)
✔ Overview page accessTime: 00:19.076, Memory: 22.48 MB
OK (6 tests, 51 assertions)
Remaining self deprecation notices (14)
2x: \Drupal\Core\Render\Element\FormElement::processGroup() is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use \Drupal\Core\Render\Element\FormElementBase::processGroup() instead. See https://www.drupal.org/node/3436275 →
2x in AddressFormsTest::testCrud from Drupal\Tests\geo_entity_address\Functional2x: \Drupal\Core\Render\Element\FormElement::valueCallback() is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use \Drupal\Core\Render\Element\FormElementBase::valueCallback() instead. See https://www.drupal.org/node/3436275 →
2x in AddressFormsTest::testCrud from Drupal\Tests\geo_entity_address\Functional1x: \Drupal\Core\Render\Element\FormElement::preRenderGroup() is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use \Drupal\Core\Render\Element\FormElementBase::preRenderGroup() instead. See https://www.drupal.org/node/3436275 →
1x in AddressFormsTest::testCrud from Drupal\Tests\geo_entity_address\Functional1x: Renderer::renderPlain() is deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Instead, you should use ::renderInIsolation(). See https://www.drupal.org/node/3407994 →
1x in AddressFormsTest::testCrud from Drupal\Tests\geo_entity_address\Functional1x: Drupal\geo_entity_tz\GeonamesTimezone::getTimezone(): Implicitly marking parameter $radius as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezone::timezoneRequest(): Implicitly marking parameter $radius as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezone::timezoneRequest(): Implicitly marking parameter $lang as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezone::timezoneRequest(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezoneInterface::getTimezone(): Implicitly marking parameter $radius as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezoneInterface::timezoneRequest(): Implicitly marking parameter $radius as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezoneInterface::timezoneRequest(): Implicitly marking parameter $lang as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit1x: Drupal\geo_entity_tz\GeonamesTimezoneInterface::timezoneRequest(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead
1x in GeonamesServiceTest::testConfigMissing from Drupal\Tests\geo_entity_tz\Unit