Enforce return types to non-inheritable navigation methods

daniel.j → changed the visibility of the branch 3480135-enforce-return-types to hidden.

daniel.j → changed the visibility of the branch 3480135-enforce-return-types to active.

Added method return types and removed corresponding ignored errors from `.phpstan-baseline.php`.

The remaning ignored errors for the navigation module in `.phpstan-baseline.php` relate to methods included in the navigation module via traits from other modules. I've only addressed changed to the navigation module strictly, so have left these ignored errors for now.

Please see the MR, a review would be great. Thanks!

MR looks good to me. Thank you!

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased onto 11.x and resolved conflicts.

Please review again, thanks!

Hello @daniel

I have taken a look at MR and it seems to be correct

Moving the issue at RTBC
Thank You let's wait for some more feedbacks

LGTM! RTBC +1

nod_ → closed merge request !10100

Committed 49af37c and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.