Only the active source type tab is included in the tabindex

Created on 10 October 2024, about 2 months ago

Problem/Motivation

from the list of available source type tabs only the active one is included in the tab index on admin/modules/browse. All the other available source types tabs are not reachable by the keyboard that way. (see tabindex.mp4)

Steps to reproduce

if you first get on admin/modules/browse the drupal.org json:api tab is active. try to reach the recipes tab just with the keyboard without using the mouse.

Proposed resolution

include all enabled source type tabs into the tabindex

๐Ÿ› Bug report
Status

Active

Version

2.0

Component

User experience

Created by

๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @rkoller
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    and i just noticed in tabs.svelte starting in line 12 the onKeydown function the user is able to instead of moving between the focus states with the arrow keys instead of the tab button. in addition to the point added in the proposed resolution adding all visible tabs to the tab index i would also remove the keyboard navigation by the arrow key since it is breaking with the usage pattern used in other parts of the admin UI that also has secondary tabs (for example on admin/structure/types/manage/article/display )

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sourav_paul Kolkata
  • Pipeline finished with Failed
    about 2 months ago
    Total: 423s
    #311416
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sourav_paul Kolkata

    I don't feel droping onKeydown() is better approach as after doping the function, can't switch project browser tabs using arrow keys Or tab.

  • i would also remove the keyboard navigation by the arrow key since it is breaking with the usage pattern used in other parts of the admin UI that also has secondary tabs (for example on admin/structure/types/manage/article/display )

    This explains the reason why we need to drop onKeydown().
    Also the GitlabCI is not passing so marking it NW again.

  • Pipeline finished with Failed
    about 2 months ago
    Total: 463s
    #311488
  • Pipeline finished with Running
    about 2 months ago
    #311502
  • Even though the CI might fail but everything under the scope of the issue is done.So marking it NR for any feedbacks on the changes or any suggestions.

  • Pipeline finished with Success
    about 2 months ago
    Total: 550s
    #311575
  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    thanks for the update @utkarsh_33. i've manually tested and the secondary tabs are all included in the tabindex now while it is not possible to navigate those secondary tabs by the left and right arrow key. so from a functional perspective this looks good to go. the tests are also green. i would say this issue is RTBC and let chris or who is reviewing the issue in the end decide if filterByCategory() should be dealt within this issue or a followup. but a followup seems the better pick as you've already suggested in one of the comments on gitlab.

  • Pipeline finished with Skipped
    about 2 months ago
    #311622
  • First commit to issue fork.
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    Thanks for the report!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024