- Issue created by @rkoller
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
and i just noticed in tabs.svelte starting in line 12 the onKeydown function the user is able to instead of moving between the focus states with the arrow keys instead of the tab button. in addition to the point added in the proposed resolution adding all visible tabs to the tab index i would also remove the keyboard navigation by the arrow key since it is breaking with the usage pattern used in other parts of the admin UI that also has secondary tabs (for example on
admin/structure/types/manage/article/display
) - Merge request !601Issue #3479907: Only the active source type tab is included in the tabindex โ (Merged) created by sourav_paul
- ๐ฎ๐ณIndia sourav_paul Kolkata
I don't feel droping onKeydown() is better approach as after doping the function, can't switch project browser tabs using arrow keys Or tab.
i would also remove the keyboard navigation by the arrow key since it is breaking with the usage pattern used in other parts of the admin UI that also has secondary tabs (for example on admin/structure/types/manage/article/display )
This explains the reason why we need to drop onKeydown().
Also the GitlabCI is not passing so marking it NW again.Even though the CI might fail but everything under the scope of the issue is done.So marking it NR for any feedbacks on the changes or any suggestions.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
thanks for the update @utkarsh_33. i've manually tested and the secondary tabs are all included in the tabindex now while it is not possible to navigate those secondary tabs by the left and right arrow key. so from a functional perspective this looks good to go. the tests are also green. i would say this issue is RTBC and let chris or who is reviewing the issue in the end decide if filterByCategory() should be dealt within this issue or a followup. but a followup seems the better pick as you've already suggested in one of the comments on gitlab.
- First commit to issue fork.
-
chrisfromredfin โ
committed 1926a049 on 2.0.x authored by
sourav_paul โ
Issue #3479907 by utkarsh_33, sourav_paul, rkoller: Only the active...
-
chrisfromredfin โ
committed 1926a049 on 2.0.x authored by
sourav_paul โ
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
Thanks for the report!
Automatically closed - issue fixed for 2 weeks with no activity.