- Issue created by @thejimbirch
- π¦πΊAustralia pameeela
+1 to this :)
I was initially quite confused by the empty pages in Drupal CMS!
- Merge request !9795Adds Taxonomy view and dependency on the views module. β (Open) created by thejimbirch
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
If possible, if this is accepted, could it be merged back into 10.3 also for Drupal CMS?
- πΊπΈUnited States Danny Englander San Diego
danny englander β changed the visibility of the branch 11.x to hidden.
- πΊπΈUnited States Danny Englander San Diego
danny englander β changed the visibility of the branch 3479665-add-view-to-tags-recipe to hidden.
- πΊπΈUnited States Danny Englander San Diego
danny englander β changed the visibility of the branch 3479665-add-view-to-tags-recipe to active.
- πΊπΈUnited States Danny Englander San Diego
danny englander β changed the visibility of the branch 11.x to active.
- πΊπΈUnited States Danny Englander San Diego
I tested the issue fork herein with D11dev and followed the steps in the summary. The article tag indeed linked to its taxonomy page thereafter.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
@smustgrave the pipeline failure is a phpcs error. This change has no code changes, only config. It has to be unrelated.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Tests are green. Unrelated failure.
- πΊπΈUnited States phenaproxima Massachusetts
No objections from me.
There was some discussion in Slack about this. @alexpott pointed out that Taxonomy has an implicit dependency on Views, which is bad, but we also agreed that it's not in the recipe's scope to fix that.
Therefore, we'll open a follow-up for Taxonomy to provide a fallback way to display terms when Views is not enabled. It will be a crappy fallback, but that's better than a broken link. In practice, most sites use Views anyway.
This, however, is a case where it is okay for the tags_taxonomy recipe to assert the (justified!) opinion that taxonomy terms look and work best when you have Views. So, the solution in this issue is good to go once we have that follow-up to address the underlying hole in the Taxonomy module.
- πΊπΈUnited States phenaproxima Massachusetts
NW for that follow-up and todo. Once that exists and is mentioned in the recipe, feel free to kick this directly back to RTBC.
-
alexpott β
committed 0b6cc939 on 10.3.x
Issue #3479665 by thejimbirch, danny englander, phenaproxima, pameeela:...
-
alexpott β
committed 0b6cc939 on 10.3.x
-
alexpott β
committed c9a88d2c on 10.4.x
Issue #3479665 by thejimbirch, danny englander, phenaproxima, pameeela:...
-
alexpott β
committed c9a88d2c on 10.4.x
-
alexpott β
committed b24c8a92 on 11.0.x
Issue #3479665 by thejimbirch, danny englander, phenaproxima, pameeela:...
-
alexpott β
committed b24c8a92 on 11.0.x
-
alexpott β
committed 2fddf325 on 11.x
Issue #3479665 by thejimbirch, danny englander, phenaproxima, pameeela:...
-
alexpott β
committed 2fddf325 on 11.x
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 2fddf325c0d to 11.x and b24c8a92f69 to 11.0.x and c9a88d2cf79 to 10.4.x and 0b6cc939da9 to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.