- Issue created by @drubb
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.
Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.
- 🇩🇪Germany drubb Sindelfingen
Thanks for taking a look. Yes, there are related projects where most commits are by me:
https://www.drupal.org/project/media_thumbnails →
https://www.drupal.org/project/media_thumbnails_pdf →
https://www.drupal.org/project/media_thumbnails_svg →The first two have been opted in by a new co-maintainer recently.
- 🇮🇳India rushiraval
Update this application summary for project you want to review for which most of commit done by you.
- 🇩🇪Germany drubb Sindelfingen
Ok, I've now switched the application to Media Thumbnails SVG:
https://www.drupal.org/project/media_thumbnails_svg →
It has a bit more PHP code, but not much more, due to its nature as plugin.
The project with the most code written by me would be https://www.drupal.org/project/media_thumbnails → ,
but this project already has been opted in for security coverage.