- Issue created by @rhovland
- Merge request !45Issue #3478149: Removed the breakpoint 'xs' and added 'xl, xxl' breakpoint for carousel. → (Merged) created by Tirupati_Singh
- 🇮🇳India Tirupati_Singh
Hi, I've removed the
xs
breakpoint for bootstrap 5 and added thexl
,xxl
for the carousel and grid. I'm attaching screenshots of the before and after fixes for reference. Please review the changes.Thanks!
- 🇺🇸United States rhovland Oregon
Xs is still a valid breakpoint. What's not valid is specifying xs in class names.
For example
col-xs -> col
display-xs-block -> display-blockThe Extra Small option still needs to exist, but the css code it sets is different than the rest and simply setting it to blank won't work either because then you end up with
col-
ordisplay--block
which is also invalid class names. - 🇺🇸United States shelane
I was just looking at that. There are two functions in the ViewsBootstrap utility class that are not used anywhere. There is getColSize, which was used (or is used) in the 8.x-3.x branch. Then there is getColumnPrefix.
public static function getColumnPrefix($breakpoint) { return 'col' . ($breakpoint != 'xs' ? '-' . $breakpoint : ''); }
It seems even when it was added, it wasn't actually called anywhere. However, this may be useful in this situation.
-
shelane →
committed b7e9b022 on 5.5.x authored by
tirupati_singh →
Issue #3478149: Breakpoint xs is used in class names which is invalid
-
shelane →
committed b7e9b022 on 5.5.x authored by
tirupati_singh →
- 🇺🇸United States shelane
The grid was working as it was. It correctly had col-val for the class. The carousel breakpoint class was incorrectly putting the xs. I updated the code with the forms, preprocess functions, schema, template, etc.
Thanks.
Automatically closed - issue fixed for 2 weeks with no activity.