Fix the issues reported by PHP_CodeSniffer

Created on 30 September 2024, about 2 months ago

Problem/Motivation

FILE: xnttxml\src\Plugin\ExternalEntities\StorageClient\XmlFiles.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
37 | ERROR | [x] Multi-line function declarations must have a trailing
| | comma after the last parameter
65 | ERROR | [x] Multi-line function declarations must have a trailing
| | comma after the last parameter
104 | WARNING | [x] '@todo: use setting tag name to get the value.' should
| | match the format '@todo Fix problem X here.'
147 | WARNING | [x] '@todo: use a setting to define root tag element.' should
| | match the format '@todo Fix problem X here.'
163 | WARNING | [x] '@todo: use a setting to define entity tag element.'
| | should match the format '@todo Fix problem X here.'
174 | WARNING | [x] '@todo: use a setting to define entity tag element.'
| | should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: xnttxml\xnttxml.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Steps to reproduce

Run phpcs command to get the drupal coding standard issues.

Proposed resolution

Many of the issues can be fixed by running the phpcbf command. For the remaining ones, we will need to manually address and then commit these changes before pushing them.

📌 Task

Status

Needs work

Version

1.0

Component

Code

Created by

🇺🇸United States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051

Live updates comments and jobs are added and updated live.

Merge Requests

!3Fix the issues reported by PHP_CodeSniffer
Open
🇺🇸United States sunil jolapara
updated about 2 months ago

Comments & Activities

Issue created by @sunil jolapara
Merge request !3Resolve #3477772 "Fix the issues reported by phpcodesniffer" → (Open) created by sunil jolapara
Pipeline finished with Success
about 2 months ago
#297049
Comment about 2 months ago →
🇺🇸United States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
Comment about 2 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to phpcs.

Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024