- Issue created by @mondrake
- ๐บ๐ธUnited States smustgrave
Ran test-only feature
1) Drupal\KernelTests\Core\File\MimeTypeTest::testFileMimeTypeDetection Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'application/x-font' +'application/x-compress' /builds/issue/drupal-3477346/core/tests/Drupal/KernelTests/Core/File/MimeTypeTest.php:53
Issue summary appears complete and change makes sense to me
Don't see anything else holding it up.
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
One minor comment about a slight loss of coverage. Fine to self RTBC
-
larowlan โ
committed c00a518e on 10.3.x
Issue #3477346 by mondrake, smustgrave, larowlan:...
-
larowlan โ
committed c00a518e on 10.3.x
-
larowlan โ
committed 659b8eae on 10.4.x
Issue #3477346 by mondrake, smustgrave, larowlan:...
-
larowlan โ
committed 659b8eae on 10.4.x
-
larowlan โ
committed 99f96526 on 11.0.x
Issue #3477346 by mondrake, smustgrave, larowlan:...
-
larowlan โ
committed 99f96526 on 11.0.x
-
larowlan โ
committed a5b0f9cc on 11.x
Issue #3477346 by mondrake, smustgrave, larowlan:...
-
larowlan โ
committed a5b0f9cc on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
19 days ago 3:34pm 29 November 2024 - ๐ฉ๐ชGermany h1nds1ght
This change introduced an issue if you have filenames which are equal to 0 (i.e. 0.jpg), because the while condition does not apply:
while (array_shift($file_parts)) {
I appended a patch to adjust this condition and fix the issue in my case.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
@et.cetera see ๐ ExtensionMimeTypeGuesser::guessMimeType must support file names with "0" (zero) like foo.0.zip Active for that bug fix.