- Issue created by @amritsingh09
The problem here is related to the version of PHP and Drupal9.
It looks like you have a version below 8.0 because trailing comma in parameters list is only available since PHP 8.0.
According to the documentation, starting from Drupal 9.1.0 you can use PHP 8.0 - https://www.drupal.org/docs/understanding-drupal/how-drupal-9-was-made-a... →
- 🇺🇸United States pianomansam
starting from Drupal 9.1.0 you can use PHP 8.0
Yes, but Drupal 9 is compatible with PHP >7.3 so this module should be as well, OR it should explicitly call out the PHP 8.0 requirement in its composer.json file and d.og module page. And if the incompatibility is simply due to an extra comma as the patch in #2 suggests, I highly recommend just fixing that so it can support a wider installation base.
- 🇺🇸United States pianomansam
FWIW the patch in #2 does NOT catch all the stray commas that make this module incompatible with PHP 7.x
- 🇳🇱Netherlands idebr
Drupal 9 is end of life as of November 1st 2023, see https://www.drupal.org/about/announcements/blog/drupal-9-is-end-of-life →
No need for modules to support a Drupal version that is end of life.
- 🇺🇸United States pianomansam
This module has a release for Drupal 9, though. If this module doesn't want to support Drupal 9, it should have a separate release that doesn't support Drupal 9.
- 🇳🇱Netherlands idebr
The minimum core_version_requirement was never formally raised, I opened a new issue at 📌 Raise minimum Drupal version to 10.2 Active to update the info files
- 🇩🇪Germany webflo
After consultation with the other maintainers, we have decided to only support Drupal 10.2+ and PHP 8.2+.
@pianomansam I am sorry, but I want to focus on stabilizing and modernizing. That it hard to to with Drupal 9 and PHP 7 in mind. I don't have the capacity to maintain two versions of the module.
- 🇺🇸United States pianomansam
@webflo, that's completely understandable. I will be moving off Drupal 9 and PHP 7 as soon I can. In the meantime, I'm just trying to leave a breadcrumb trail for anyone else who may come along and experience the same issue. Would it be possible to document the decision from this issue and #3481514 on the module's home page? I realize it's too late to modify the composer.json in 2.0.0-beta2 to enforce PHP 8, but mentioning the requirement on the home page would be very helpful.