- Issue created by @ammaletu
What is the webform text format used for?
It is to ensure a text format exists for the WebformHtmlEditor form element.
This is probably related to π Text format webform_default can not be used outside of webform module Fixed , but as a support request, won't be acted on.
- π©πͺGermany ammaletu Bonn, Germany
I didn't want to outright label it as a bug, although I do think that it is one. There already is an unanswered question on Drupal Answers: https://drupal.stackexchange.com/questions/320170/what-is-the-purpose-of...
From a practical point of view, the whole thing boils down to "Do webform users need this text format or only webform admins"?
The answer to that is probably "only webform authors". If you could figure out a way to make existing text formats accessible to the webform author in this widget, I suppose that would be an improvement. But that would be in a context of having read every prior issue pertaining to this matter to understand the maintainers' position on this one.
- First commit to issue fork.
- πΊπΈUnited States jrockowitz Brooklyn, NY
I was able to reproduce the issue, and this seems like a simple bug that should be addressed. Please review the MR.
- Merge request !519Issue #3477051: The hidden webform text format leads to text format selects with only one option β (Merged) created by jrockowitz
- π©πͺGermany ammaletu Bonn, Germany
I tested the change and it works perfectly! Users with more text formats still see the dropdown without the webform text format. And my registered users without any other text formats don't see the Plain text select anymore.
Thanks a lot for the quick patch! I just added two comments to the MR, concerning typos in comments.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Thanks for the patch and review. Those typos should be fixed first.
- πΊπΈUnited States jrockowitz Brooklyn, NY
@ammaletu Thank you for the code review.
- π¦πΊAustralia pameeela
Just wanted to note that π Disabled text formats can't be seen in the GUI Fixed makes this format visible in the list in 10.4+ and 11.1+, which is.... not ideal. Not sure what the solution is though.
- πΊπΈUnited States jrockowitz Brooklyn, NY
Let's resolve this issue via π Webform text format appears in the formats list Active
- πΊπΈUnited States jrockowitz Brooklyn, NY
I think the root cause of this issue in in Drupal 11.1 users could be assigned the 'use text format webform_default' permission.
Let's block this from happening and write an update hook to suppress the permission.
- πΊπΈUnited States jrockowitz Brooklyn, NY
Yep, we need this dedicated MR, which now has test coverage.
- Status changed to Needs review
22 days ago 12:41am 27 November 2024 - πΊπΈUnited States jrockowitz Brooklyn, NY
Once the tests pass, let's merge this.
- 770711ed committed on 6.3.x
Issue #3477051: The hidden webform text format leads to text format...
- 770711ed committed on 6.3.x
- 11f92780 committed on 6.3.x
Issue #3477051: The hidden webform text format leads to text format...
- 11f92780 committed on 6.3.x
- 770711ed committed on 6.x
Issue #3477051: The hidden webform text format leads to text format...
- 770711ed committed on 6.x
- 11f92780 committed on 6.x
Issue #3477051: The hidden webform text format leads to text format...
- 11f92780 committed on 6.x