- Issue created by @Anybody
- Merge request !9590Trigger error, if context parameter string is malformed. β (Open) created by Anybody
- Merge request !9591Different approach, as parameters are optional anyway β (Open) created by Anybody
- π©πͺGermany Anybody Porta Westfalica
Implementing the validation, I had the idea that it might be even better to just pad the optional values, if missing.
Of course, we could also combine both approaches.So I think it might make sense to get some feedback, which way we should go here. Also it would be good to know if we should trigger a warning, throw an exception or just log this into watchdog.
- π©πͺGermany Anybody Porta Westfalica
@quietone apologies for the glitch!
- π©πͺGermany Anybody Porta Westfalica
Just had a look at the failing test, but I can't see any relation?
- πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch 3476390-validate-contextual-id-string to hidden.
- πΊπΈUnited States smustgrave
Hiding other MR
Failure appeared random in 11.x
Fix seems pretty straight forward. - π³πΏNew Zealand quietone
There are questions in #4 that need to be discussed.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.