Contrib.social

Improve the "No tour" button

Open on Drupal.org →
Created on 22 September 2024, 2 months ago

Problem/Motivation

At the moment the "No tour" button has added the disabled attribute. That way the button is excluded from the tabindex and is unavailable and not clickable. In the aural interface in safari for example you get No tour dimmed dialog popup button. Btu there are a few problems at the moment that might need some improvement:

for the navigation module and the admin_toolbar module:

  • it might be potentially confusing if you are tabbing through the tab index and you dont run into the disabled button while if you open the rotor you till notice the button instead. Or if someone relies mainly on tabbing the button simply might get missed.

only for the navigation module:

  • you are still able to see a style change when you hover the no tour button which is inconsistent, for the "keyboard cursor" the button is unavailable while for the mouse cursor you see the hover style and the cursor switches to a pointer instead of a prohibition sign like the admin_toolbar module does.

Audited and discussed the issue together with @drupa11y last tuesday.

Steps to reproduce

Proposed resolution

to tackle the first point that applies to the navigation and admin_toolbar modules, the suggestion is to change the attribute from disabled to aria-disabled that way the button would still semantically be announced as disabled but it would be kept in the tabindex and it would remain styleable. (see https://kittygiraudel.com/2024/03/29/on-disabled-and-aria-disabled-attri... and https://adrianroselli.com/2024/02/dont-disable-form-controls.html ).

for the second point only applying to the navigation module, suggestion is to simply remove the styling on the hover state and make sure that the mouse pointer also shows the prohibtion sign like with admin_toolbar

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

2.0

Component

User interface

Created by

🇩🇪Germany rkoller Nürnberg, Germany

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024