- Issue created by @sunil jolapara
- Status changed to Needs review
2 months ago 1:04pm 20 September 2024 - šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- šµšPhilippines cleavinjosh
Hi @zaryab_drupal,
Thank you for providing an MR. I applied MR!13, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
:ā content_readability git:(2.2.0) curl https://git.drupalcode.org/project/content_readability/-/merge_requests/13.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 6359 0 6359 0 0 13648 0 --:--:-- --:--:-- --:--:-- 13704 patching file README.md patching file css/styles.css patching file src/Controller/ContentReadabilityAjaxController.php patching file src/Controller/ContentReadabilityController.php patching file src/Form/ContentReadabilityAddProfile.php patching file src/Form/ContentReadabilityAdminSettingsForm.php patching file src/Form/ContentReadabilityDeleteProfile.php patching file src/Form/ContentReadabilityEditProfile.php ā content_readability git:(2.2.0) ā .. ā contrib git:(main) ā git status ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_readability FILE: /Users/interns/Demo-site/drupal_11_test/install-dir/drupal_11_test_site/web/modules/contrib/content_readability/content_readability.info.yml -------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically -------------------------------------------------------------------------------------------------------------------------------------------------- Time: 361ms; Memory: 12MB ā contrib git:(main) ā
Please note that I cloned the module and did not download the module via composer.
Thank you.
- š®š³India kulpratap2002
@cleavinjosh Please review it, i have solved all codesniffer issues.
- šµšPhilippines cleavinjosh
Hi @kul.pratap,
Thank you for updating the MR. I applied MR!13, it was applied smoothly and fixed all the phpcs issues.
ā content_readability git:(2.2.0) curl https://git.drupalcode.org/project/content_readability/-/merge_requests/13.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 11386 0 11386 0 0 25537 0 --:--:-- --:--:-- --:--:-- 25529 patching file README.md patching file content_readability.info.yml patching file css/styles.css patching file js/readability.js patching file js/readability_ckeditor4.js patching file src/Controller/ContentReadabilityAjaxController.php patching file src/Controller/ContentReadabilityController.php patching file src/Form/ContentReadabilityAddProfile.php patching file src/Form/ContentReadabilityAdminSettingsForm.php patching file src/Form/ContentReadabilityDeleteProfile.php patching file src/Form/ContentReadabilityEditProfile.php ā content_readability git:(2.2.0) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_readability ā contrib git:(main) ā
Thank you.