Suppress Symfony debug classloader deprecations for ArrayAccess

Seems straight forward.

One inline comment

Replied to the comment - I think it's correct as-is.

Fair point, this is a PHP native class.

BTW I am now curious to understand from where the DebugClassloader is getting the potential typehint given it’s not in an annotation of a .php file. I will dig a bit.

What is the class/method that is causing the deprecation, though? I tried removing the return types from the ArrayAccess implementation methods in Drupal\Core\Template\Attribute and run locally the Drupal\Tests\Core\Template\AttributeTest test, but it does not trigger in that case.

@mondarake it's in the OpenTelemetry code base, not Drupal:

1) /builds/project/drupal/vendor/symfony/error-handler/DebugClassLoader.php:341
Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "OpenTelemetry\SDK\Common\Attribute\AttributesBuilder" now to avoid errors or add an explicit @return annotation to suppress this message.

https://git.drupalcode.org/project/drupal/-/jobs/2818033

OK but then this is an indirect deprecation, and I would suggest to add the ignore a bit below in the apposite section

# Indirect deprecations. These are not in Drupal's remit to fix, but it is
# worth keeping track of dependencies' issues.
%Method "[^"]+" might add "[^"]+" as a native return type declaration in the future. Do the same in implementation "org\\bovigo\\vfs\\[^"]+" now to avoid errors or add an explicit @return annotation to suppress this message%

With symfony/phpunit-bridge we could skip indirect deprecations; with our replacement not, at least as-is.

That's a good idea, hadn't even noticed that section...

Made a commit for this, but for whatever reason I can't currently reproduce the deprecation notice running tests locally so not properly tested yet.

Test failures seem random to me.

Would be good to run the performance tests, but I cannot trigger them manually.

Kicked off a run with the OTEL_COLLECTOR environment variable set, which should be close/identical to the scheduled job.

https://git.drupalcode.org/project/drupal/-/jobs/2818376

Thanks

All questions have been answered. I have updated credit.

Requeued pipeline

larowlan → closed merge request !9541

Committed to 11.x - does this need a backport?