- Issue created by @Grevil
- 🇩🇪Germany Grevil
Note, that currently we won't show the "hide_360_logo" option through states, if the control checkbox is activated!
This is the default behaviour of the library, so I don't think we should change it (in the Drupal module), nor should we spend time on it @Anybody?
- First commit to issue fork.
- 🇩🇪Germany Anybody Porta Westfalica
There's nothing we can do about it here. We should not implement any special behavior for this. Maybe one day that will be fixed in the library or not...
As this might be confusing for users (and us), we should simply link the issue in the settings description, until that's solved.
@Grevil: I read the sentence:
Note, that currently we won't show the "hide_360_logo" option through states, if the control checkbox is activated!
several times and looked into the code, but don't understand what's meant here. Could you explain it, if it's relevant or link the line of code you're talking about?
- Merge request !6Add description about the special behavior of hide_360_logo → (Merged) created by Anybody
@anybody State API, conditional fields. If "enable controls" is true, the "show 360 logo" option is hidden.
But... auum, @grevil this seems wrong? The 360° logo setting depends on the autoplay setting. If autoplay is true, the 360 logo will never appear. So if autoplay is true => hide the "show 360 logo" option.
And yes, without custom code there is nothing we can do here. From my point of view it is fine to set this to 'not fixed'.
-
thomas.frobieter →
committed 86ffcb68 on 1.x authored by
anybody →
Issue #3475501 by anybody, grevil, thomas.frobieter: Enabling the "...
-
thomas.frobieter →
committed 86ffcb68 on 1.x authored by
anybody →
- 🇩🇪Germany Anybody Porta Westfalica
Root cause must then be fixed upstream. If that will ever happen, the description link can be removed.
- 🇩🇪Germany Grevil
Huh? This issue should be a reminder, for when the issue is fixed upstream. Nothing more.
- 🇩🇪Germany Grevil