- Issue created by @sunil jolapara
- Status changed to Needs review
4 months ago 11:21am 18 September 2024 - šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- Issue was unassigned.
- Status changed to RTBC
4 months ago 11:43am 18 September 2024 - šµšPhilippines cleavinjosh
Hi @sunil jolapara,
Thank you for providing an MR. I applied MR!2, it was applied smoothly and fixed the phpcs issues.
ā view_mode_crop git:(1.0.x) curl https://git.drupalcode.org/project/view_mode_crop/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2391 0 2391 0 0 5164 0 --:--:-- --:--:-- --:--:-- 5164 patching file css/view_mode_crop.ui.css patching file src/PathProcessor/DownloadPathProcessor.php patching file view_mode_crop.module ā view_mode_crop git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml view_mode_crop ā contrib git:(main) ā
Thank you.
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs
.Furthermore, since GitLab CI is now enabled for all the projects, GitLab CI should be used to get PHP_CodeSniffer errors/warnings.
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3475198-fix-the-issues to hidden.
- š®š¹Italy apaderno Brescia, š®š¹
- š®š³India kulpratap2002
I have resolved all the remaining phpcs error but pipeline is not passed.
- šµšPhilippines cleavinjosh