[2.0.x] Migrate wizard.

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. 2.0.x-alpha1 is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

2. Fix phpcs issues.

See attached file - migrate_wizard-phpcs-issues.txt →

3. FILE: migrate_wizard.libraries.yml

version: VERSION

VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.

Hi, thanks for your help.

I have fixed all the points you have indicated:
I have deleted the branch that was wrong.
I have corrected all the points in phpcs on my local and I have uploaded the changes to the 2.0.x branch.
I have deleted the line you have indicated from the migrate_wizard.libraries.yml file.

If you need me to make any further changes, please let me know.

Thank you very much for your help.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Hi, I've fixed some bugs that were in the 2.0.x branch.

If you've already started the review, please excuse me.

Regards.

Provide Readme.md files as per requirement in #2.

Please refer Documentation Checks →

• The following points are just a start and don't necessarily encompass all the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issues, or does not correctly use the Drupal API; the single points are not ordered, not even by importance

src/Controller/DbListBuilder.php

Entity handler implementations are part of the public API and cannot be used as parent class. Only interfaces can be used from contributed modules.
Entity handlers are not controllers; their namespace should not contain Controller.

src/Controller/OriginFieldCollectionItemController.php

Since the class does not use any ControllerBase method, it does not need to use ControllerBase as base class. Controllers do not need to have a specific parent class; as long as they implement \Drupal\Core\DependencyInjection\ContainerInjectionInterface, they are fine.

  /**
   * Constructs a new EntityListBuilder object.
   *
   * @param \Drupal\migrate_wizard\MWManageDataService $mw_manage_data_service
   *   The MWManageDataService.
   */
  public function __construct(MWManageDataService $mw_manage_data_service) {
    $this->mwManageDataService = $mw_manage_data_service;
  }

The short description is for another class.

src/Entity/OriginVocabularyInterface.php

This interface, like other defined interfaces, is empty. The code could use the extended interface.

Hi avpaderno,

First of all, thank you for your instructions.

I think I have solved everything you have indicated.

In the controllers, I have added a base controller MWControllerBase, which implements ContainerInjectionInterface and I extend that in all my controllers.

Also in that controller I use some traits that I needed (these were already in the original ControllerBase), but now the rest of ControllerBase is no longer there, only what I need :).

I have moved the listbuilders to the entity folder and fixed the namespaces.

I have removed the interfaces of the entities that were not needed.

I await further instructions if there are any.

Thank you very much.

Regards

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.