Drupal\Tests\migrate\Unit\destination\EntityRevisionTest uses weird mocking pattern

MR 9636 is ready for review.

I did some related cleanup:

• Replace prophesize('\Fully\Qualified\ClassName') with prophesize(ClassName::class).
• Mock getKey('id') and getKey('revision') in the setUp() method instead of three of the test methods.

The $storage prophecy (mock object) gets some additional, incompatible, constraints in some of the test methods, so I did not reveal() it in the setUp() method. I did add a type declaration and fix its @var comment.

Two functional tests failed, but not the test that I changed.

Test definitely looks cleaner. Big + for the typehint variables.

Committed to 11.x, this should qualify for backport to 10.4.x for under the Critical API compatibility condition.

Setting to Path (to be ported) for a 10.4 version. Would be good to get a green test run before I cherry-pick.

larowlan → closed merge request !9636

I cherry-picked and squashed the commits from the original MR onto the 10.4.x branch. Is there an easier way to test on 10.4.x?

An unrelated FunctionalJavascript test failed: Drupal\Tests\ckeditor5\FunctionalJavascript\ImageUrlTest.

Some unrelated Functional tests failed:

• Drupal\Tests\block\Functional\BlockTest
• Drupal\Tests\block\Functional\BlockCacheTest

I re-ran the failing tests, and now they are all green.

Thanks, cherry-picked to 10.4.x

larowlan → closed merge request !9952

Automatically closed - issue fixed for 2 weeks with no activity.