ComponentPluginManager must implement CategorizingPluginManagerInterface

I will try to propose a MR.

Looking forward to an MR to review! 🤓

If you wish, you can have a look on an existing and well tested implementation of this interface for SDC plugin manager: https://git.drupalcode.org/project/ui_patterns/-/blob/2.0.x/src/Componen...

Implemented the changes required in the MR. Please review.

One test failed:

    There was 1 failure:
    
    1)
    Drupal\Tests\layout_builder\Functional\LayoutSectionTest::testLayoutSectionFormatterAccess
    Behat\Mink\Exception\ResponseTextException: The text "Hello test world" was
    not found anywhere in the text of the current page.
    
    /builds/issue/drupal-3474533/vendor/behat/mink/src/WebAssert.php:907
    /builds/issue/drupal-3474533/vendor/behat/mink/src/WebAssert.php:293
    /builds/issue/drupal-3474533/core/tests/Drupal/Tests/WebAssert.php:979
    /builds/issue/drupal-3474533/core/modules/layout_builder/tests/src/Functional/LayoutSectionTest.php:311
    /builds/issue/drupal-3474533/core/modules/layout_builder/tests/src/Functional/LayoutSectionTest.php:210

Rebased, LayoutSectionTest passed locally for me so perhaps an unrelated random fail, let's see what happens on CI.

Alternatively why can't we just add category as the trait requires, and copy it from group with a default? See MR!10245.

Assigning to Wim for review.

#14: interesting alternative! And very pragmatic 👏

Just one nit: I think the default group should be defined in \Drupal\Core\Theme\ComponentPluginManager::$defaults 😊 That makes it more explicit, less magical.

#14 is not doable, we need a translatable string but you can't call t() or new TranslatableMarkup when initialising a class property.

Fixed PHPStan, the baseline addition will be removed in 📌 Fix PHPStan L1 errors "Call to method getDefinitions()/getSortedDefinitions() on an unknown class Drupal\Core\Plugin\CategorizingPluginManagerTrait." Needs work

Ah, good point, @longwave! This is the most pragmatic approach, then :)

One question on the MR about the phpstan baseline changes - if someone can confirm they're needed.

Fine to self RTBC afterwards

See #17, the problem is in the trait, PHPStan doesn't catch it if you run it on the file alone - not sure why.

Alternatively if we land 📌 Fix PHPStan L1 errors "Call to method getDefinitions()/getSortedDefinitions() on an unknown class Drupal\Core\Plugin\CategorizingPluginManagerTrait." Needs work first then the baseline changes can be removed.

larowlan → changed the visibility of the branch 3474533-componentpluginmanager-must-implement to hidden.

Credits

Rerolled after 📌 Fix PHPStan L1 errors "Call to method getDefinitions()/getSortedDefinitions() on an unknown class Drupal\Core\Plugin\CategorizingPluginManagerTrait." Needs work , only removed the baseline changes, if it comes back green will commit

Committed to 11.x - thanks!

larowlan → closed merge request !10245

Automatically closed - issue fixed for 2 weeks with no activity.