Reorganize navigation settings to be more consistent

MR created.

Not sure how this kind of changes should be handled regarding change records or deprecation notices for experimental modules.

Any example would've welcome.

Left some comments/questions on MR.

Believe since it's experimental deprecation isn't needed? But don't quote me.

Code suggestions applied and added new comments.

A new round would be great!

My question has been answered. Still curious about the validation but don't see anything wrong with the schema.

We should use a hook_update_N here because it is a schema change. The config in the prior state is not valid anymore. Also when we convert it we should change it to ->save(TRUE) as we know the config has the correct type.

Thank you for your review @alexpott.

Made the changes requested and tests are still green. Took the freedom to move it back to RTBC.

Given the module is in beta we need a CR for this change. Also I have one question on the MR about the config structure.

CR created and addressed question about config structure.

Committed and pushed d23a9f3706 to 11.x and 181fba584a to 11.0.x. Thanks!

Backported to 11.0.x as navigation is experimental. We could even backport this to 10.x and use https://www.drupal.org/node/3459876 → if we like. I'll leave this decision to @plopesc.

@alexpott I'm fine leaving it as it is unless you have special concerns about it.

Should we publish the CR once the issue has been fixed? Or should we wait until 11.0.6 is released?

This prevented a backport of 📌 Store the file path instead of ID for the navigation logo Needs work to 10.4.x, I think we should either backport all navigation issues or none, since it's experimental, I would go for all until it's at rc/stable then we might want to freeze it on 10.x then.

Discussed with @alexpott in slack and cherry-picked to 10.4.x

Automatically closed - issue fixed for 2 weeks with no activity.