- Issue created by @rkoller
- Merge request !72Issue #3473706: Navigation sidebar interferes with tour highlights on narrow viewports โ (Merged) created by smustgrave
- Status changed to Needs review
2 months ago 5:00pm 17 September 2024 - Status changed to RTBC
2 months ago 6:07pm 17 September 2024 - ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
argh i will never learn that i have to execute git pull regularily on every branch. forgot that on 2.0.x and wondered why the hotkey wasnt working which i needed to actually test. luckily i remembered. added two videos. working like a charm now. thank you!
-
smustgrave โ
committed f1c701f0 on 2.0.x
Issue #3473706: Navigation sidebar interferes with tour highlights on...
-
smustgrave โ
committed f1c701f0 on 2.0.x
- Status changed to Fixed
2 months ago 6:26pm 17 September 2024 - ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
I believe this is effecting large viewports also which causes a ton of movement when you start and stop a tour.
Re-opening this. If another issue should be opened, please let me know.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
yep i agree. i've raised that concern somewhere else as well. either on another issue or in a followup discussion on slack. but completely agree, i would only collapse the sidebar for mobile viewports where the sidebar has the close button, for larger viewports dont collapse the sidebar when a tour is started.
-
smustgrave โ
committed f990ec67 on 2.0.x
Resolve #3473706 "Attempt2"
-
smustgrave โ
committed f990ec67 on 2.0.x
- ๐บ๐ธUnited States smustgrave
Added a check for 1024. Will see if it fixes โจ Add a route parameter for the Dashboard initiative's Dashboard entity. Needs work
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
since i was unable to properly test yesterday due to the misbehavior i'Ve mentioned on slack i just retested the changes that got committed to 2.0.x meanwhile and i can confirm that the behavior is as expected now. thank you!
Automatically closed - issue fixed for 2 weeks with no activity.