- Issue created by @fazilitehreem
- First commit to issue fork.
- Merge request !266#3472507: `Duplicate` action does not generate new UUIDs for components in slots, resulting in duplicate UUIDs β (Merged) created by utkarsh_33
- Assigned to jessebaker
- Status changed to Needs review
3 months ago 9:54am 6 September 2024 - Assigned to utkarsh_33
- Status changed to Needs work
3 months ago 11:59am 6 September 2024 - π¬π§United Kingdom jessebaker
This is not passing the tests yet. Please ensure the tests pass before setting status to Needs review.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I was just able to duplicate a two column component without issue.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
But after duplicating one with components in it, components in the slots are all gone.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I cannot reproduce this either.
- Status changed to Active
3 months ago 9:09am 9 September 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Ah! I can, and the symptoms are actually super obvious:
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This relates to π Improve/Refactor replaceUUIDsAndUpdateModel() and insertMultipleNodes() Active , in that we should have unit test coverage for this too.
- Issue was unassigned.
- Assigned to utkarsh_33
- Issue was unassigned.
- Status changed to Needs review
2 months ago 6:32am 11 September 2024 - Assigned to jessebaker
- Issue was unassigned.
- Status changed to Needs work
2 months ago 11:21am 12 September 2024 - Status changed to Needs review
2 months ago 7:36am 16 September 2024 I have tried writing unit tests for the first time, so might not match the coding standardsπ . Please review the changes.
- Assigned to balintbrews
- π³π±Netherlands balintbrews Amsterdam, NL
Assigning to myself for review.
- Assigned to utkarsh_33
- Status changed to Needs work
2 months ago 6:55pm 16 September 2024 - π³π±Netherlands balintbrews Amsterdam, NL
Great job with the fix, @utkarsh_33! Duplicating components with slots filled with children works after your changes! π I left you a few comments on the code β fixing one regression and some clean-up remains to be done before we can merge.
- Assigned to balintbrews
- Status changed to Needs review
2 months ago 4:58am 17 September 2024 I have updated the code according to requested changes.Please review them.Their might be some more feedbacks on 11bd33b4 change, but rest i think i have addressed most of the changes.
- Assigned to utkarsh_33
- Status changed to Needs work
2 months ago 8:01am 17 September 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@balintbrews' feedback at https://git.drupalcode.org/project/experience_builder/-/merge_requests/2... is not yet addressed.
- Assigned to balintbrews
- Status changed to Needs review
2 months ago 11:03am 17 September 2024 - Assigned to utkarsh_33
- Status changed to Needs work
2 months ago 11:09am 17 September 2024 - Assigned to balintbrews
- Status changed to Needs review
2 months ago 11:52am 17 September 2024 - Assigned to jessebaker
- π³π±Netherlands balintbrews Amsterdam, NL
This looks good to me. Assigning to @jessebaker for a final round of review.
- Status changed to RTBC
2 months ago 1:22pm 17 September 2024 -
jessebaker β
committed 2f857fbc on 0.x authored by
utkarsh_33 β
Issue #3472507 by utkarsh_33, balintbrews, wim leers: `Duplicate` action...
-
jessebaker β
committed 2f857fbc on 0.x authored by
utkarsh_33 β
- Issue was unassigned.
- Status changed to Fixed
2 months ago 2:40pm 17 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.