- Issue created by @fazilitehreem
- First commit to issue fork.
- Merge request !266#3472507: `Duplicate` action does not generate new UUIDs for components in slots, resulting in duplicate UUIDs β (Open) created by Utkarsh_33
- Assigned to jessebaker
- Status changed to Needs review
10 days ago 9:54am 6 September 2024 - Assigned to Utkarsh_33
- Status changed to Needs work
10 days ago 11:59am 6 September 2024 - π¬π§United Kingdom jessebaker
This is not passing the tests yet. Please ensure the tests pass before setting status to Needs review.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I was just able to duplicate a two column component without issue.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
But after duplicating one with components in it, components in the slots are all gone.
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
I cannot reproduce this either.
- Status changed to Active
7 days ago 9:09am 9 September 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Ah! I can, and the symptoms are actually super obvious:
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
This relates to π Improve/Refactor replaceUUIDsAndUpdateModel() and insertMultipleNodes() Active , in that we should have unit test coverage for this too.
- Issue was unassigned.
- Assigned to Utkarsh_33
- Issue was unassigned.
- Status changed to Needs review
6 days ago 6:32am 11 September 2024 - Assigned to jessebaker
- Issue was unassigned.
- Status changed to Needs work
4 days ago 11:21am 12 September 2024 - Status changed to Needs review
about 12 hours ago 7:36am 16 September 2024 I have tried writing unit tests for the first time, so might not match the coding standardsπ . Please review the changes.
- Assigned to balintk
- Assigned to Utkarsh_33
- Status changed to Needs work
about 1 hour ago 6:55pm 16 September 2024 - ππΊHungary balintk
Great job with the fix, @utkarsh_33! Duplicating components with slots filled with children works after your changes! π I left you a few comments on the code β fixing one regression and some clean-up remains to be done before we can merge.