- Issue created by @Liam Morland
- Merge request !18Issue #3472119: Add ::accessCheck() to entity queries → (Merged) created by Liam Morland
- Status changed to Needs review
4 months ago 3:16pm 4 September 2024 - 🇨🇦Canada joseph.olstad
I would have to check, this change is likely not necessary and might actually cause an exception.
Entity query example:
\Drupal::entityQuery('node') ->accessCheck(FALSE)
Here's the original change notice. No mention of entityTypeManager
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This is raised as an issue by
upgrade_status
. I believe this applies to any entity query not just those created with\Drupal::entityQuery('node')
. - Status changed to RTBC
4 months ago 9:27pm 4 September 2024 - 🇨🇦Canada smulvih2 Canada 🍁
@liam good call on this, it looks correct. The getQuery() method generates an entity query object, so adding the access check here makes sense, especially with upgrade_status flagging this.
- 🇨🇦Canada joseph.olstad
Hmm, ok, sounds good, seeing as this is for behat code, if it does fail it'll fail in the pipeline.
-
liam morland →
committed 8d1a698b on 5.3.x
Issue #3472119: Add ::accessCheck() to entity queries
-
liam morland →
committed 8d1a698b on 5.3.x
- Assigned to smulvih2
- 🇨🇦Canada joseph.olstad
Hmm, ok I pushed it into gitlab however it also has to go into github for the pipeline to be triggered.
- 🇨🇦Canada joseph.olstad
@smulvih2 , please push to upstream , let's see what the pipeline does.
-
smulvih2 →
committed d719e83c on 5.3.x
Issue #3472119 by liam morland, joseph.olstad: Add ::accessCheck() to...
-
smulvih2 →
committed d719e83c on 5.3.x
- 🇨🇦Canada smulvih2 Canada 🍁
Merged this with the latest 5.3.x branch, thanks for the work boys!
Automatically closed - issue fixed for 2 weeks with no activity.