- Issue created by @thejimbirch
- ๐บ๐ธUnited States smustgrave
So not super clear is the desire just to have an icon?
- ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
Icon and the word Tour
Then the labels should be on hover/using the HTML title Attribute
<button class="toolbar-icon toolbar-item toolbar-icon-help" aria-pressed="false" type="button" disabled title="[label-text]">Tour</button>
- ๐บ๐ธUnited States smustgrave
Maybe can add a checkbox to use labels as titles and have default just be โTourโ
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
re #4 โจ Tour and No Tour available button labels should not be required Active you mean adding that checkbox to
admin/config/user-interface/tour/settings
? and what would be the default for no tour, just "No tour"?and in that context i also wonder since there are two opposite camps would it make sense in a follow up issue to make if the "no tour" button is shown or not configurable as well? so the site builder is able to choose if the button should be show if no tour is available or not?
- ๐บ๐ธUnited States smustgrave
Thatโs definitely a follow up because it reintroduces an issue with paragraphs
- Assigned to smustgrave
- Status changed to Needs review
3 months ago 4:38pm 6 September 2024 - ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
I think I failed at testing this. Will try again later.
-
smustgrave โ
committed 97acc25c on 2.0.x
Resolve #3470806 "Tour and no"
-
smustgrave โ
committed 97acc25c on 2.0.x
- Status changed to Fixed
2 months ago 2:16pm 17 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.