- Issue created by @Kristen Pol
- Assigned to f.mazeikis
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
- +1 for not auto-adding
- -1 for not auto-updating
- And needs a follow-up for auto-deleting if and only if there is zero usage โ but for that we'll first need component usage tracking โ which requires the "component present in
tree
" equivalent of ๐ Prevent fields from being deleted if they are used in Experience Builder field's dynamic prop values Active (which does "field type present inprops
".
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Oh and โฆ I guess the "hide them" piece is still important too: we'd have to update
\Drupal\experience_builder\Controller\SdcController::getComponentsList()
to do that, but that'd require being able to know for a givenComponent
config entity whether it should be displayed or not.This seems perfect for
\Drupal\Core\Config\Entity\ConfigEntityInterface::enable()
+\Drupal\Core\Config\Entity\ConfigEntityInterface::disable()
? i.e. when a component becomes obsolete, we'ddisable()
it?I defer to @f.mazeikis :)
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
๐ New component requirement: each SDC prop must have StorablePropShape Active is in โ making this much more actionable!
- ๐ฌ๐งUnited Kingdom f.mazeikis Brighton
+1 to using
enable()
/disable()
for now
Implementing a new requirement "must not be obsolete" for auto-adding is simple enough
Auto-delete needs in-use tracking, as per #3 ๐ New component requirement: obsolete SDCs must not be auto-added, but must be auto-updated Active . - ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
Based on #3454125-75: Implement temporary design system for the DrupalCon Barcelona demo โ , bumping this to . The ability to
::disable()
aComponent
config entity would be a huge productivity boost for the fine folks working on https://www.drupal.org/project/demo_design_system โ ๐ - Merge request !225#3470424: New component requirement: obsolete SDCs must not be auto-added, but must be auto-updated โ (Merged) created by Unnamed author
- Issue was unassigned.
- Status changed to RTBC
3 months ago 3:09pm 29 August 2024 -
Wim Leers โ
committed 3f0986c1 on 0.x authored by
f.mazeikis โ
Issue #3470424 by f.mazeikis, Wim Leers, kristen pol: New component...
-
Wim Leers โ
committed 3f0986c1 on 0.x authored by
f.mazeikis โ
- Status changed to Fixed
3 months ago 3:21pm 29 August 2024 - ๐บ๐ธUnited States Kristen Pol Santa Cruz, CA, USA
Just confirming that this is working as expected. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.