New component requirement: each SDC prop must have StorablePropShape

Without this requirement, a Component may appear in the UI that can not be populated at all, or only partially.

After this, 📌 [PP-2] Add ComponentAuditabilityTest Active likely becomes more important than it already is.

Tempted to bump to . This will be super confusing otherwise.

Looks like this is 99% done😄🥳

A grand total of 2 remarks now, and it’ll be trivial to address both 😊

Can you please also update docs/data-model.md, specifically this line:

- MAY require `SDC`s to meet certain criteria (such as: MUST have `title` for each prop, MUST have `example` for each required prop)

… because the new criteria we're adding here actually are specifically for the data model — i.e. to ensure we only allow using SDCs that are actually supported/fully usable.

Seems critical IMO. Blocked by this at the moment :)

Blocked by this at the moment :)

Agreed that without this, it's annoying/painful to test additional components in XB!

Bumped priority 👍

We’ve got this pretty close to done, but it is still failing Cypress test. Specifically, due to Shoe Button (components/simple/shoe_button/shoe_button.component.yml) component missing. It is not being auto-generated as there’s no StorablePropShape for it’s icon prop.
The way I see us resolving this:

• Removing/updating cypress test (I originally was thought it was testing a feature we need, but @wim-leers tells me otherwise)
• Prioritising this might resolve #3467890 📌 [later phase] Support `{type: object, …}` prop shapes that require *multiple* field types — also: nested components/component reuse Postponed , but that issue was deprioritised and would take quite a while
• We could consider adding another hardcoded match for icon shape prop in Drupal\experience_builder\SdcPropJsonSchemaType::computeStorablePropShape as we are already doing for image (L243), but it also needs #3467890 📌 [later phase] Support `{type: object, …}` prop shapes that require *multiple* field types — also: nested components/component reuse Postponed

I'll proceed with removing or modifying the failing Cypress test.

• Removing/updating cypress test is not an option, as I assume it tests feature that we expect XB to have

Why did you conclude it is “a feature we expect XB to have”? That’s definitely not the case. It wasn’t listed in xb-general.cy.js at all until 📌 Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria Fixed landed last week!

So 💯 for this choice.

• Prioritising this might resolve #3467890, unless I’m reading it wrong, but it might take quite a while?

This would take VERY long, has just been literally deprioritized by Lauri (I see he didn’t post that on d.o — fixed that: #3467890-11: [later phase] Support `{type: object, …}` prop shapes that require *multiple* field types — also: nested components/component reuse → ).

It’d take too long to unblock e.g. the people working on https://www.drupal.org/project/demo_design_system →

• We could consider adding another hardcoded match for icon shape prop in Drupal\experience_builder\SdcPropJsonSchemaType::computeStorablePropShape as we are already doing for image (L243), but it also needs #3467890 📌 [later phase] Support `{type: object, …}` prop shapes that require *multiple* field types — also: nested components/component reuse Postponed

this is a viable choice … if there is a field type that can do all this. And there isn’t. It needs 3 different string enums. That simply means we need 📌 [later phase] Support `{type: object, …}` prop shapes that require *multiple* field types — also: nested components/component reuse Postponed indeed. I’ll capture it an example on that issue 👍

P.S.: Any component that is not showing up yet is essentially an implicit @todo. Just like \Drupal\Tests\experience_builder\Kernel\PropShapeRepositoryTest::getExpectedUnstorablePropShapes() is doing that explicitly.

Captured shoe_button's icon as an example at #3467890-12: [later phase] Support `{type: object, …}` prop shapes that require *multiple* field types — also: nested components/component reuse → .

I think I found dead/duplicate test coverage … and a weakness in the test infra that we overlooked in 📌 Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria Fixed — left a suggestion to harden that 😊

Finally: this needs an update to docs/data-model.md — see #5.

Sorry but where/what is "3.1.2.b"? My brain is becoming mush :D

@kristen pol it's a section in that *.md file.

@f.mazeikis There's 3 pieces of feedback not yet addressed.

This would've prevented 🐛 Component config entities are incomplete: missing entries for optional props, causing errors in ComponentPropsForm Fixed . Crediting @kristen pol for creating that issue, which further confirms the need for this 👍

Holy shit that was super tricky: https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... 😬

I’ve been in the very depths of the kerneltestbase shenanigans in the past, otherwise I probably wouldn’t have figured it out either.

Should be all green now!

Random fail in E2E test:

      cy:command ✔  assert	expected **<input#edit-xb-component-props-static-static-card1ab-cta1-0-value.rt-reset.rt-TextFieldInput>** to have value **ponytail**
                    Actual: 	"ponytail"
                    Expected: 	"ponytail"
      cy:command ✔  get	[data-drupal-selector="component-props-form"] [data-drupal-selector="edit-xb-component-props-static-static-card1ab-cta2-0-value"]
      cy:command ✔  focus	
      cy:command ✘  clear	
      cy:command ✘  uncaught exception	TypeError: Cannot read properties of null (reading 'offsetHeight')

Cannot reproduce this locally: https://git.drupalcode.org/project/experience_builder/-/jobs/2578070/art...(failed).png — passes just fine.

Retrying: https://git.drupalcode.org/project/experience_builder/-/jobs/2578268.

Automatically closed - issue fixed for 2 weeks with no activity.