Add (more) bool return typehints to protected test helper methods

Seems straight forward.

I can't wait till typehints are required.

Unfortunately, a few more instances have crept into the code. It seems we will be chasing our tail for a while on these. Let's get an update on this and then ping me when it is ready.

Added a few more:

• \Drupal\Tests\comment\Functional\CommentTestBase::commentExists
• \Drupal\Tests\comment\Functional\CommentTestBase::commentContactInfoAvailable
• \Drupal\KernelTests\AssertContentTrait::assertNoFieldByName

I intentionally left out the following:

• \Drupal\Tests\user\Functional\UserRegistrationRestTest::registerUser because it would add a union type
• \Drupal\KernelTests\AssertContentTrait::getSelectedItem because the @return annotation is wrong

Adding where work on AssertContentTrait is being done.

I intentionally left out the following:

\Drupal\Tests\user\Functional\UserRegistrationRestTest::registerUser because it would add a union type
\Drupal\KernelTests\AssertContentTrait::getSelectedItem because the @return annotation is wrong

Should follow ups be made for those?

Should follow ups be made for those?

I've updated the parent / meta to mention union types in the remaining tasks. I think that also covers AssertContentTrait::getSelectedItem as I think it should return string|false.

Sounds like a plan

Committed acd24cb and pushed to 11.x.

Thanks!

quietone → closed merge request !9324

Automatically closed - issue fixed for 2 weeks with no activity.