Drupal core's `FileMediaFormatterBase::mimeTypeApplies()` function is using the `explode()` function without properly handling the case where a `null` value might be passed to it. This leads to a deprecated function warning in PHP 8.1 and above, where passing `null` to the second parameter of `explode()` is no longer allowed.
The deprecation warning is triggered when accessing the media display settings for a file, particularly when the MIME type cannot be determined, and `null` is returned.
1. Install a Drupal site on PHP 8.1 or above.
2. Navigate to **/admin/structure/media/manage/file/display**.
3. Observe the deprecation warning related to the `explode()` function being logged or displayed.
Add a null check in the `FileMediaFormatterBase::isApplicable()` method before passing the value to the `mimeTypeApplies()` method. This will prevent the `explode()` function from receiving a `null` value and resolve the deprecation warning.
**Code Change:**
```php
/**
* {@inheritdoc}
*/
public static function isApplicable(FieldDefinitionInterface $field_definition) {
if (!parent::isApplicable($field_definition)) {
return FALSE;
}
/** @var \Symfony\Component\Mime\MimeTypeGuesserInterface $extension_mime_type_guesser */
$extension_mime_type_guesser = \Drupal::service('file.mime_type.guesser.extension');
$extension_list = array_filter(preg_split('/\s+/', $field_definition->getSetting('file_extensions')));
foreach ($extension_list as $extension) {
$mime_type = $extension_mime_type_guesser->guessMimeType('fakedFile.' . $extension);
// Add null check to avoid passing null to mimeTypeApplies().
if ($mime_type !== null && static::mimeTypeApplies($mime_type)) {
return TRUE;
}
}
return FALSE;
}
```
- [ ] Write and apply the code patch.
- [ ] Review the patch.
- [ ] Test the patch to ensure it resolves the deprecation warning.
- [ ] Submit the patch or merge request for inclusion in Drupal core.
There are no user interface changes introduced by this fix. The change is solely within the backend PHP code.
No new terminology is introduced.
No API changes are introduced. This change is purely a bug fix and maintains backward compatibility.
There are no data model changes involved in this fix.
Fixed a deprecation warning in `FileMediaFormatterBase::isApplicable()` where `null` was being passed to the `explode()` function, which is not allowed in PHP 8.1 and later versions.
Closed: duplicate
11.0 🔥
Don't see anything to review but changes should be against 11.x
These kind of error also usually require some research to figure out why the value is null at that point. Putting a null or empty check can be masking a larger issue.
