- Issue created by @pdureau
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Thanks! I'm super slammed today but will see if I can look at this tomorrow :)
- Assigned to smustgrave
- πΊπΈUnited States smustgrave
May be something I can tackle if @kristin pol doesnβt beat me
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Iβm slammed until November π
- First commit to issue fork.
- Merge request !203Issue #3469805 by pdureau, kristen pol: [2.0.0-beta2] Some UX tweaks in Component validator β (Merged) created by mogtofu33
- Issue was unassigned.
- Status changed to Needs review
2 months ago 11:07am 12 September 2024 - π«π·France mogtofu33
Not sure if I have fully match the request but improved the 'filter messages' with checkbox instead of a select, better messages when errors levels are filtered. Highlight of the 'Render' being not available if no stories.
- Assigned to pdureau
- Issue was unassigned.
- Status changed to Needs work
2 months ago 11:15am 12 September 2024 - π«π·France pdureau Paris
Hi Jean,
Not tested, but just reading the MR, did you address this part:
"Render: {{ story_id }" and "HTML rendered: {{ story_id }}" use the
#story
property of the SDC render element, which is resolved by https://git.drupalcode.org/project/ui_patterns/-/blob/2.0.x/modules/ui_p...So:
- Do we add a dependency from ui_patterns_devel to ui_patterns_library ?
- Do we add a condition to show "Render: {{ story_id }" and "HTML rendered: {{ story_id }}" fields only if ui_patterns_library is activated?
Also, in commit message, don't forget to credit yourself and no need to put the target release. So instead of this:
Issue #3469805 by pdureau, kristen pol: [2.0.0-beta2] Some UX tweaks in Component validator
do this:
Issue #3469805 by mogtofu33, pdureau, kristen pol: Some UX tweaks in Component validator
-
pdureau β
committed e96dfa0a on 2.0.x authored by
mogtofu33 β
Issue #3469805 by mogtofu33, pdureau, kristen pol: Some UX tweaks in...
-
pdureau β
committed e96dfa0a on 2.0.x authored by
mogtofu33 β
- Status changed to Fixed
2 months ago 1:00pm 12 September 2024 - Status changed to Fixed
2 months ago 7:24pm 15 September 2024