Update SDDS SDCs attributes prop to align with XB

Thanks!

The code in XB enforces the 'attribute' prop to be of type Drupal\Core\Template\Attribute
web/modules/contrib/experience_builder/src/PropShape.php

      // TRICKY: `attributes` is a special case — it is kind of a reserved
      // prop.
      // @see \Drupal\sdc\Twig\TwigExtension::mergeAdditionalRenderContext()
      // @see https://www.drupal.org/project/drupal/issues/3352063#comment-15277820
      if ($prop_name === 'attributes') {
        assert($prop_schema['type'][0] === Attribute::class);
        continue;
      }

So, If 'attribute' prop is added with any other type (like type: string for most of the SDDS components), XB UI will break.

Since it's after midnight in India, having Jacob pick this one up now.

Assigning this to me as per conversation with @jacobadeutsch

Updated script for above

https://github.com/qed42/twig-sdc-yaml-generator/blob/main/twig_sdc_yaml...

Moving this to needs work as I have just updated the script and not other parts of issue.

Thanks!

@jacobadeutsch Can you update your local script to not put the required fields section in? That was breaking XB when I was testing. I would like it out until it's done properly per:

📌 Add required props for all SDDS baseline SDC YAML files Fixed

And the 80 char fixes got reverted in this:

https://git.drupalcode.org/project/demo_design_system/-/merge_requests/2...

so you'll need to manually changes those again... or maybe we just plan on fixing those at the end at this point. I can reopen the mega linter ticket and we can plan on a pass when the code is in better shape.

jacobadeutsch → closed merge request !26

jacobadeutsch → reopened merge request !26

fixed the required fields thing

This is looking good. There are some regressions for 80 char (manual) fixes. I'll reopen that issue so we can do it later on if we want to revisit these.

components/01-atoms/fieldset/fieldset.component.yml
description: >
        Description display: before, after, invisible. Default is before.
        Optional.

description: >
        'Type of the message: error, warning, info, success. Default is error.'

components/01-atoms/label/label.component.yml
description: >
        'Label size: extra-large, large, regular, small, extra-small.'

components/01-atoms/select/select.component.yml
description: >
              'Option type: option group (optgroup) or option (option).'

components/02-molecules/social-links/social-links.component.yml
description: >
              Direction: horizontal, vertical. Defaults to horizontal.

components/02-molecules/tooltip/tooltip.component.yml
description: >
        Symbol to use in the button. Defaults to
        'userinterface_informationmark'.

starshot_demo/components/01-atoms/starshot-heading/starshot-heading.component.yml
description: >
        Font style of heading: drupal-2, drupal-3, drupal-4, drupal-5, drupal-6,
        drupal-7, drupal-8.

Merged.

Reopening this based on new information:

https://www.drupal.org/project/experience_builder/issues/3468944#comment... 📌 Update XB's `image` SDC to comply with best practices, and document those best practices Needs review

we may need to just remove these but I'm double checking.

kristen pol → credited pdureau → .

Pierre confirmed we don't need this so we can remove it. Note that we have some big MRs pending so let's remove these after those are merged today.

Assigning to Jacob.

These were removed as part of:

📌 Add examples for all props in all SDDS baseline SDC YAML files Fixed

Note that the XB team isn't so sure about removing this so they have postponed their issue:

📌 Remove attributes in XB components Needs review

Hopefully we won't need to add attributes back in! o_O

Marking fixed for now though.

Automatically closed - issue fixed for 2 weeks with no activity.