- Issue created by @Kristen Pol
- Assigned to sea2709
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Note that for now I have removed all "required" from all components so this is less of a priority right now. Still important to do at some point though :) [but removes the urgency]
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Since we've removed required section for now, changing title and summary to reflect.
- Assigned to joshua1234511
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
@sea2709 I'm going to assign this to Joshua for now as I see you've been working on XB issues which are more important right now :)
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
We can work on this but we may want to hold off on merging until this is fixed:
🐛 Emptying a required value through the UI crashes the app Active
- Assigned to annmarysruthy
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks @annmarysruthy. I let @joshua1234511 know that someone was going to focus on this one.
- Merge request !33issue #3469522:add required properties to component.yml files → (Closed) created by annmarysruthy
- 🇮🇳India annmarysruthy
annmarysruthy → changed the visibility of the branch 3469522- to hidden.
- 🇮🇳India annmarysruthy
annmarysruthy → changed the visibility of the branch 3469522- to active.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 12:49pm 29 August 2024 - 🇮🇳India annmarysruthy
Raised MR !34 for adding required props to component.yml files. Kindly review
- Assigned to jacobadeutsch
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to Jacob for review.
- First commit to issue fork.
- Status changed to Needs work
3 months ago 7:34pm 30 August 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
It's looking pretty good but I noticed a few things. I didn't get that drush cr error btw.
- Assigned to Kristen Pol
- Status changed to Needs review
3 months ago 9:17pm 3 September 2024 - Status changed to RTBC
3 months ago 4:58pm 5 September 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Looks good for now. We can tweak as needed. I'll get this merged in. Thanks!
-
kristen pol →
committed 70567208 on 1.0.x authored by
annmarysruthy →
Resolve #3469522
-
kristen pol →
committed 70567208 on 1.0.x authored by
annmarysruthy →
- Issue was unassigned.
- Status changed to Fixed
3 months ago 5:02pm 5 September 2024 -
kristen pol →
committed 70567208 on feature/civictheme-font-integration authored by
annmarysruthy →
Resolve #3469522
-
kristen pol →
committed 70567208 on feature/civictheme-font-integration authored by
annmarysruthy →
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Note that there may have been XB-related issues with using required, so I've commented them out for now. But, they are there if we want to uncomment and test as we are testing individual components.
Automatically closed - issue fixed for 2 weeks with no activity.