Decide where the focus should return to when a tip dialog modal is closed

From my understanding of a modal the focus has to return to where it started. So it should return to the "take tour" button.

yep i am also leaning towards that approach

I have added the CSS for highlight the "Take a Tour" button once the model popup close. please review.

I have verified & applied changes working fine for me, on click on modal close button , "Take a tour button page" button highlight with grey color & attached the screencast as well moving to RTBC.

Can the eslint issue be addressed.

possible to do with vaniella javascript vs jquery?

I've addressed the feedback by replacing the jQuery line with vanilla JavaScript. this resolved the ESLint issues in the pipeline, Thank you for the guidance, Please review.

thanks for working on the MR. I've quickly tested and i have one observation and one general question.

You were adding the focus with that.el.style.border = '2px solid gray';. That way your are using your own focus outline and dont use the focus outline set for the theme.with admin_toolbar as the toolbar the color contrast is too low and the outline barely visible. it doesnt mean the actual focus outline would be meeting SC2.4.7 with admin toolbar but still i would use the themes focus styling by for example using the focus() method in javascript?

the only question i am not sure 100% about is how to handle the case when the toolbar is available for a user, the user is on a page in the frontend that has added the tour button and that page has a tour? which of the two buttons to focus? strictly speaking tour would have to remember which of the two was pressed for starting the tour and fall back to this one with the focus when the tour is exited?

Updated for focus call.

thanks! I've tested three scenarios:

1) I've started a tour on admin/appearance (as admin). the focus gets back to the "take a tour of this page" button when the tour is closed.
2) When i am on a page for a node node/2 as admin and i have the "take a tour of this page" button in the admin_toolbar and the socials sidebar in olivero the focus always returns to the button in the sidebar when the tour is closed (no matter which of the two buttons was used to open the tour) .
3) when i open node/2 in a private window, open the tour by pressing the button in the social sidebar, and close the tour again the button in the social sidebar isnt regaining focus.

i'll set back the issue to needs work. point 3 should be fixed within this issue imho. point 2 is up to debate how to handle the redundant button case, but guess better in a followup?

#3 you sure? I tested the same wayand focus goes right back to the button.

yes i am sure. and Interesting i think i figured out why i havent seen a focus outline. i've closed the tour tip by the mouse. take a look at the brief video. first just navigated by the keyboard in the second try i used the mouse for closing the tour tip.

Pushed a new fix if that doesn't fix it and @shalini_jha doesn't pick it back up over night will try and look at Monday.

looks like it was fixed. nice!

Rock on. There is a setting to the focus call but not supported by many browsers yet.

Automatically closed - issue fixed for 2 weeks with no activity.