- Issue created by @Mark Shi
- Assigned to Indranil Roy
- 🇮🇳India Indranil Roy kolkata
Hi @mark shi,
The patch successfully solves the problem, but there's an issue when we click on 'Select all media.' It selects the media, but the message fails to update. Attaching screenshots for reference.
I'm currently working on this issue and will raise the MR soon. - Merge request !9278Issue #3469322: Fixed media grid media select issue. → (Open) created by Indranil Roy
- Issue was unassigned.
- Status changed to Needs review
3 months ago 11:17am 21 August 2024 - 🇮🇳India Kanchan Bhogade
Hi
I've tested MR 9278 on Drupal 10.3.x
The MR is applied cleanly on my local;
but in the issue summary MR shows as "Open Pipeline Failed"Testing Steps:
1. Go to /admin/content/media-grid
2. Click the image item (not the checkbox) and the count is not updated.Test Result:
The Selection count gets updated when directly clicking on the media image and clicking on 'Select all media'.
RTBC+1Attaching Scrrenshots
keeping "Needs Review" for code verification
- 🇮🇳India prashant.c Dharamshala
Yes, I confirm that this issue exists in
11.x
as well and changes fix the issue. We should work on a fix in11.x
and then the fix will get backported. - 🇮🇳India prashant.c Dharamshala
prashant.c → changed the visibility of the branch 3469322-selection-count-does to hidden.
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
A reminder, that changes to the UI should have before and after screenshots available to reviewers from the Issue Summary.
I think we should have a test for this, adding tag.
- Status changed to Needs work
3 months ago 5:00am 22 August 2024 - 🇮🇳India prashant.c Dharamshala
Thanks @quietone
Some unrelated tests are failing, we need to check. In addition to this we need new tests as well as per #12.