The page title "edit tour" is too generic

Try this

Looks good! the only minor nitpick i've just noticed. would it make sense to wrap the tour name in an em tag in the h1? so it is in line with the pattern used on for example content types (admin/structure/types/manage/article), block types (admin/structure/block-content/manage/basic) and so on?

Done

the em tags are getting rendered.

Oops

now the order looks off:

instead of
$form['#title'] = $this->t('Edit tour <em>%label</em>', ['%label' => $this->entity->label()]);
better
$form['#title'] = $this->t('Edit <em>%label</em> tour', ['%label' => $this->entity->label()]);

Following what node and block content do

oh i now see and understand what you are referring to. so under the top level menu item content the order is "edit [entity type] [entity name]" that is what you were referring to, while under the top level menu item structure it is the other way around "Edit [entity name] [entity type]" which is what i was referring to. the latter, front loading, is in the context of readability the preferable and recommended choice. a few months ago we've ping ponged about that very topic between the ux and a11y meetings. a summary and the outcome of those discussions can be found in this followup issue that picked up some of the outcomes: https://www.drupal.org/project/drupal/issues/3370946#comment-15203381 🐛 Page title should contextualize the local navigation Needs work and i've also created a google doc comparing all h1s and page titles across drupal admin ui https://docs.google.com/spreadsheets/d/1XhQtXZA1JCwa8qnE3vp8gyW8HJT8zZxg... . and that front loading pattern is something i have strong opinions on. was a good reminder to revisit the following follow up issue 📌 Refine the page title if possible Active .

Cuz the problem i have with the "edit tour custom block edit" example. you start with "edit" then you get way more "general" and then you get more specific again with the actual title. the context, that you are within a tour, you already know before, since you got onto that edit page from the tour list page.
while the other way around, first you know you are on an edit page then you know what document you are editing, the "custom block edit" page and then you get to know the context that it is a tour. screenreader users as well as sighted users can jump off at any time with this pattern. screenreader users skim with their ears sighted users with their eyes. with "edit tour custom block edit" you first have to scan edit (the action) then tour (the context) and then finally starts part of interest. while with "edit custom block edit tour" you start with edit then custom .... maybe that is already enough, the person knows they are in custom block edit... while if they are uncertain about the context they can still go on for reassurance that they are within a tour. (in case there are several open tabs for example or they have a small working memory).

both approaches, the one you suggested and the one i suggested would be sort of consistent with the rest of drupal at this point, but personally i hope it gets unified on the front loaded approach sooner or later.

thank you! looks good to me. and this issue is a good reminder to revisit the issue making the h1s and page title naming patterns consistent across the entire admin ui.

Automatically closed - issue fixed for 2 weeks with no activity.