- Issue created by @rkoller
- 🇺🇸United States smustgrave
Suggested keys? control + ?
I use control + t often so against that.
- 🇺🇸United States smustgrave
Control alt t
Maybe? I don’t use hot keys often put implementation doesn’t seem bad
- 🇩🇪Germany rkoller Nürnberg, Germany
at the moment the only hotkey i know in the context of drupal is the one set by the coffee module (alt d). so maybe using the alt key in combination with "t" might be an option? i just dont like something like control and alt. plus that might cause conflicts on the mac with voiceover. the voiceoverkey is ctrl + alt.
and hotkeys might be something that could be improved for drupal core in general. something i've noticed in the competitive review where we took a look at different CMSes in the context of a11y and the features they have. joomla for example has a directly accessible hotkey menu listing the most important keyboard shortcuts. quite handy.
- Status changed to Needs review
7 months ago 1:34am 8 September 2024 - 🇩🇪Germany rkoller Nürnberg, Germany
nice looks good! one potential problem, one that the coffee module has as well and another unrelated observation.
the problem the coffee module has is how do people discover the actual hotkey (that one is in place)? like the tour module the coffee module also has a top level menu item. but that the coffee module has a hotkey can easily be missed. i'Ve missed and overread that fact on the project page for a long long time. so i wonder would it make sense for one to also add a note about the hotkey to the project description of the tour module on d.o anyway (some people actual read that thoroughly) but i also wonder if it would make sense to add one tip to one of the tours informing the user? maybe not in the tours tour which is only about the tour admin interface but on a tour people use for onboarding? not sure what the best place would be tbh.
and on unrelated note. i've noticed i am able to jump between tour tips by pressing the arrow left and arrow right key? that was sort of unexpected. there is no indication nor visual feedback in the ui. the tip just changes. but i am also unsure how you could indicate that button press and change? (but out of the scope for this issue even unsure if it is worth an issue right now. it was just unexpected and everything looks so static "arrowing" through the tip with no feedback except the new highlights and text)
- Status changed to Needs work
7 months ago 2:29pm 9 September 2024 - Assigned to smustgrave
- 🇺🇸United States smustgrave
Definitely think we can add a note in the README and project page.
If the arrows are working for next/previous that's probably a shepherd feature because I don't see anything on our side that would do this.
- Status changed to Needs review
7 months ago 12:41am 12 September 2024 - 🇺🇸United States smustgrave
If that description looks good I'll add to the project page.
I'm skipping tests for this one as I can't figure it out and too frustrated trying haha.
- 🇺🇸United States smustgrave
If the wording works we can merge this one.
- Status changed to RTBC
7 months ago 2:19pm 17 September 2024 - 🇩🇪Germany rkoller Nürnberg, Germany
Looks like you've used my suggestion as is, so for my end no complaints.
-
smustgrave →
committed 6505deea on 2.0.x
Resolve #3469297 "Add a hotkey"
-
smustgrave →
committed 6505deea on 2.0.x
- Status changed to Fixed
7 months ago 2:41pm 17 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
5 months ago 11:27am 22 November 2024 - 🇩🇰Denmark ressa Copenhagen
Nice solution with the shortcut @smustgrave! And thanks @rkoller for making me aware of it in the related Token issue. I may create a follow up issue for Admin Toolbar Search, based on that method ...