- Issue created by @Grevil
- 🇩🇪Germany Grevil
The last compatibility fix needs to be done by @thomas.frobieter:
Check manually 0 The #drupal-off-canvas selector is deprecated in drupal:9.5.0 and is removed from drupal:10.0.0. See https://www.drupal.org/node/3305664. --------------------------------------------------------------------------------
In https://www.drupal.org/node/3305664 → is written, that instead of using the old
#drupal-off-canvas
id,#drupal-off-canvas-wrapper
should be used, but we are using both in code, so I am unsure, whether to remove the#drupal-off-canvas
or merge it together with the#drupal-off-canvas-wrapper
part. - 🇩🇪Germany Anybody Porta Westfalica
Re
#off-canvas
we can ignore that. It won't have any bad effects, just a nice reminder from Drupal. I guess we're not even using this any more?So I think you can merge this and @thomas.frobieter can have a short look if it's fine like this. We shouldn't block this on that crap ;)
- 🇩🇪Germany Grevil
We ARE using it, but we have both #drupal-off-canvas-wrapper and #drupal-off-canvas, with different css classes etc. set
- 🇩🇪Germany Anybody Porta Westfalica
Yeah I mean just in CSS, doesn't do any harm.
- Issue was unassigned.
- Status changed to Fixed
8 months ago 12:55pm 19 August 2024 - 🇩🇪Germany Anybody Porta Westfalica
Merged. @thomas.frobieter please comment and reopen if you disagree.
Oh, "module0" sounds fancy, what's that? ;D
Yes, we can safely ignore this warning about the #off-canvas selector.
Automatically closed - issue fixed for 2 weeks with no activity.