- Issue created by @mstrelan
- Merge request !9224Issue #3468435: Convert IpAddressBlockingTest to a Unit and Kernel test → (Closed) created by mstrelan
- Status changed to Needs review
4 months ago 11:22pm 15 August 2024 - Status changed to RTBC
4 months ago 2:34pm 16 August 2024 - 🇺🇸United States smustgrave
Nice find!
Tweaked the title slightly since it appears the the tests are being improved upon, evident by your comment in the MR too.
From what I can tell no coverage has been lost, as mentioned shaves a few seconds off, and even got to improve the tests it appears.
- 🇬🇧United Kingdom catch
Yes this looks great.
Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
- Status changed to Fixed
4 months ago 11:39pm 16 August 2024 - 🇩🇪Germany Anybody Porta Westfalica
Looks like
core/modules/ban/tests/src/Unit/BanAdminTest.phpis failing now?------ ----------------------------------------------------------------------
Line core/modules/ban/tests/src/Unit/BanAdminTest.php
------ ----------------------------------------------------------------------
36 Class Drupal\ban\Form\BanAdmin constructor invoked with 1 parameter,
2 required.
74 Class Drupal\ban\Form\BanAdmin constructor invoked with 1 parameter,
2 required.
95 Class Drupal\ban\Form\BanAdmin constructor invoked with 1 parameter,
2 required.
------ ----------------------------------------------------------------------See ✨ Allow bulk unbanning / removal and clearing ip addresses (Flush all) Active . Should that be fixed here (reopen) or separate issue?
- 🇩🇪Germany Anybody Porta Westfalica
Update: Sorry, I was wrong, all fine here! The other issue caused the test to fail, a comment was misleading.
All good!
Automatically closed - issue fixed for 2 weeks with no activity.