- Issue created by @Anybody
- Status changed to Needs review
about 1 month ago 5:25pm 11 November 2024
I'm currently reviewing the module's code for #3468193: [2.1.x] Entity Extra Field → and saw these lines in the module file:
$base_suggestion = $bundle_id ? $original . '__' . $entity_type_id . '__' . $bundle_id : $original . '__' . $bundle_id;
Code-wise and logically, this doesn't make sense to me and I think the variables just got turned around.
$bundle_id is more specific than $entity_type_id$bundle_id is empty, it shouldn't be usedSo I'm quite sure it should be
$base_suggestion = $bundle_id ? $original . '__' . $entity_type_id . '__' . $bundle_id : $original . '__' . $entity_type_id;
See above
Active
2.1
Code