- Issue created by @solideogloria
- Status changed to Needs review
3 months ago 3:47pm 14 August 2024 solideogloria → changed the visibility of the branch 3468139-editorconfig-https to hidden.
- Status changed to Needs work
3 months ago 3:49pm 14 August 2024 - Status changed to Needs review
3 months ago 3:52pm 14 August 2024 There we go. The initial fork defaulted to 11.0.x instead of 11.x for some reason. MR using the correct fork.
- 🇺🇸United States smustgrave
Some reason Unit tests appear to be failing?? Have 0 idea why
None of the tests themselves failed... I'm going to rerun the job.
- 🇺🇸United States smustgrave
I believe there is a ComposerIntegrationTest failure test. But re-ran twice myself
Yes, my mistake. I had to click to expand and view the full output.
Fail Other phpunit-16.xml 0 Drupal\Tests\ComposerIntegrationTes PHPUnit Test failed to complete; Error: PHPUnit 10.5.29 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.10 Configuration: /builds/issue/drupal-3468139/core/phpunit.xml.dist ........S...........................F...................... 59 / 59 (100%) Time: 00:00.679, Memory: 10.00 MB There was 1 failure: 1) Drupal\Tests\ComposerIntegrationTest::testExpectedScaffoldFiles with data set #0 ('.editorconfig', 'assets/scaffold/files/editorconfig', '[project-root]') Scaffold source and destination files must have the same contents. Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ '# Drupal editor configuration normalization\n -# @see http://editorconfig.org/\n +# @see https://editorconfig.org/\n \n # This is the top-most .editorconfig file; do not search in parent directories.\n root = true\n /builds/issue/drupal-3468139/core/tests/Drupal/Tests/ComposerIntegrationTest.php:204 FAILURES! Tests: 59, Assertions: 420, Failures: 1, Skipped: 1.
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
Ah, that explains why the MR targeted the wrong branch initially. I had selected the wrong version in the dropdown. Thanks. The MR is targeting 11.x as it should.
There appears to be an unrelated CKEditor5 test failure. Rerunning.
- Status changed to RTBC
3 months ago 6:41pm 15 August 2024 - Status changed to Needs work
3 months ago 5:56am 16 August 2024 - 🇳🇿New Zealand quietone
@solideogloria, thanks for fix.
There is a meta issue for change the URLs throughout core and this should be part of that issue and have a better scope. Making these changes for a single URL or file is time consuming for all of us.
In the meta, the scope is to do the change by the URL itself. Just a suggestion but maybe this could expand to include the cases where the URL is used once or twice? There is a script in the other issue that might be able to help to locate them.
There is more information about scope and change set size in the https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/core-scope.
- 🇺🇸United States smustgrave
Maybe this issue should be about any http that require updating scaffold?