Remove a couple of data providers from ckeditor5 ImageTestBase

Seems straight forward with no loss of coverage

Looking at this sort of thing makes me think there is some value in a version of BTB that only installs the site at the start of the entire class instead of each test run, which would probably be useful in a lot more places.

It's worth exploring but it would be hard. After finding/working on several issues like this, it's usually fairly annoying to remove the data provider, .e.g in this case the order of [TRUE, FALSE] in one of the tests matters because the test method itself is destructive to a test format created in setUp(). In other tests, we do things like create a field with the same name in every iteration.

Committed and pushed d7bb4b3b42 to 11.x and 9e2ca2c7be to 11.0.x and c756fb0c40 to 10.4.x and 66a260588e to 10.3.x. Thanks!

Despite the green test run here it seems to have broken HEAD: https://git.drupalcode.org/issue/drupal-3468435/-/jobs/2456816

Going to roll back.

Thought about this more (unfortunately), and came up with another idea.

Given trying to remove the providers in this case is fragile, we can instead split the two tests into four + traits. More files, but uses pipeline test concurrency more efficiently so that the jobs finish faster.

Before:

ImageUrlTest      13 passes  182s   

After:

ImageUrlTest       5 passes   85s 
ImageUrlProvider   8 passes  134s 

When combined with 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Active this is a major improvement in run times, from test run duration of just over 3 minutes down to 2m52 with scope to go lower.

https://git.drupalcode.org/project/drupal/-/jobs/2474093
https://git.drupalcode.org/project/drupal/-/jobs/2474094

Should this be postponed on 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Active ?

@smustgrave no it's not directly related, I've just been testing some of these with 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Active to see what the current maximum improvements are we can get.

Actually had to download this one but I believe no coverage has been lost here.

This is showing all tests failing but there are not reports, There are no test reports for this pipeline . So I decided to rebase. After that I realized that the link to the test in the block in the issue summary was not directing to the latest tests. Odd.

Let's try it again :)

It doesn't cherry pick to 11.0.x, conflict in: core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTest.php

Since 11.2 is set to release soon don’t think we need to backport to 11.0

Automatically closed - issue fixed for 2 weeks with no activity.