- Issue created by @catch
- Status changed to Needs review
3 months ago 2:05pm 13 August 2024 - Status changed to RTBC
3 months ago 3:02pm 13 August 2024 - 🇬🇧United Kingdom longwave UK
Looking at this sort of thing makes me think there is some value in a version of BTB that only installs the site at the start of the entire class instead of each test run, which would probably be useful in a lot more places.
- 🇬🇧United Kingdom catch
It's worth exploring but it would be hard. After finding/working on several issues like this, it's usually fairly annoying to remove the data provider, .e.g in this case the order of
[TRUE, FALSE]
in one of the tests matters because the test method itself is destructive to a test format created in setUp(). In other tests, we do things like create a field with the same name in every iteration. - Status changed to Fixed
3 months ago 10:00am 14 August 2024 - 🇫🇷France nod_ Lille
Committed and pushed d7bb4b3b42 to 11.x and 9e2ca2c7be to 11.0.x and c756fb0c40 to 10.4.x and 66a260588e to 10.3.x. Thanks!
- 🇬🇧United Kingdom catch
Despite the green test run here it seems to have broken HEAD: https://git.drupalcode.org/issue/drupal-3468435/-/jobs/2456816
Going to roll back.
- Status changed to Needs work
3 months ago 2:23am 16 August 2024 - Status changed to Needs review
3 months ago 8:19am 18 August 2024 - 🇬🇧United Kingdom catch
Thought about this more (unfortunately), and came up with another idea.
Given trying to remove the providers in this case is fragile, we can instead split the two tests into four + traits. More files, but uses pipeline test concurrency more efficiently so that the jobs finish faster.
Before:
ImageUrlTest 13 passes 182s
After:
ImageUrlTest 5 passes 85s ImageUrlProvider 8 passes 134s
When combined with 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Needs review this is a major improvement in run times, from test run duration of just over 3 minutes down to 2m52 with scope to go lower.
https://git.drupalcode.org/project/drupal/-/jobs/2474093
https://git.drupalcode.org/project/drupal/-/jobs/2474094 - 🇺🇸United States smustgrave
Should this be postponed on 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Needs review ?
- 🇬🇧United Kingdom catch
@smustgrave no it's not directly related, I've just been testing some of these with 📌 Add the ability to install multiple modules and only do a single container rebuild to ModuleInstaller Needs review to see what the current maximum improvements are we can get.
- Status changed to RTBC
3 months ago 2:58pm 28 August 2024 - 🇺🇸United States smustgrave
Actually had to download this one but I believe no coverage has been lost here.
- First commit to issue fork.
- 🇳🇿New Zealand quietone
This is showing all tests failing but there are not reports,
There are no test reports for this pipeline
. So I decided to rebase. After that I realized that the link to the test in the block in the issue summary was not directing to the latest tests. Odd. - Status changed to Downport
3 months ago 8:32am 4 September 2024 - 🇫🇷France nod_ Lille
Let's try it again :)
It doesn't cherry pick to 11.0.x, conflict in:
core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTest.php