Wrong handling of roles when editing a user with Role Delegation enabled

Hi,

I have resolved the 'array_diff(): Argument' issue and attached the patch.
Please review and verify.

Thanks.

I need detailed steps to reproduce the problem.

Hi rcodina@

When I changed some fields (for example first or last name - custom text field), the TypeError warning mentioned in the previous post appeared, even though I did not touch the role expiration date.
This warning is gone after the patch .#2

Thanks @sarwan_verma,
Patch is ok, it worked, the previous warning is gone. But just so you know, there are two php warnings in the log records. I don't know if it is related to the previous problem or the patch. But , it was one time warning. These two warnings did not appear in other changes.
Just FYI.

@pearls I recommend to use the latest 4.0.0 version.

@sarwan_verma Thanks for the patch. Notice branch 3.x won't receive more updates.

@pearls Are you using Role Delegation module?

Hi rcodina ,
I use Role Delegation. Now I noticed a similar issue I had before with the Administer Users by Role module and Role expiration.
Anyway.
I tested Version 4. There's no TypeError: array_diff() ... issue mentioned before.
15.patch (#8) worked without previous issue. Thanks for your effort.

FYI : It was a bit hard to upgrade to v4. I don't use rules module. There were some problems with rules, role_expire_rules. So I completely uninstalled role expire and installed with a new config.
Rules v 8.x-3.0-alpha8.
Below is the log I captured when I tried to upgrade from 3.02 to V4 and update the site database.

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "request_path" plugin does not exist. Valid plugin IDs for Drupal\rules\Core\ConditionManager are: context, request_domain, request_path_exclusion, context_all, view_inclusion, user_status, http_status_code, rules_node_is_sticky, rules_entity_field_access, rules_user_is_blocked, rules_list_contains, rules_path_alias_exists, rules_entity_is_new, rules_data_is_empty, rules_data_comparison, rules_entity_has_field, rules_user_has_role, rules_node_is_published, rules_entity_is_of_type, rules_node_is_of_type, rules_path_has_alias, rules_list_count_is, rules_node_is_promoted, rules_text_comparison, rules_entity_is_of_bundle in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /var/www/html/d10test/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

@pearls With Role Expire 4.0.0 you may not see the error but the handling of roles while in combination with Role Delegation is wrong. So please, use the patch to avoid further issues.

When updating module or core make sure you:

drush cr
drush updb -y
drush cex -y

So all hook_updates get executed and changes in configuration get stored.

Thanks for the feedback!

@pearls Follow the ECA integration progess on ✨ Make Rules integration a sub-module, provide ECA integration Active

Automatically closed - issue fixed for 2 weeks with no activity.